Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #9802 to 6.6: Remove X-Pack foo Metricbeat module from reference file #9804

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Dec 27, 2018

Cherry-pick of PR #9802 to 6.6 branch. Original message:

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder.

After merging MS SQL module in X-Pack, we can already remove this dummy module.

Things that have been removed:

  • module folder and all its contents module/foo
  • References to the module and metricset in include/list.go file
  • Reference in the metricbeat.reference.yml file.

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder.

After merging MS SQL module in X-Pack, we can already remove this dummy module.
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The PR description needs an update as only a small subset of this was backported.

@sayden sayden changed the title Cherry-pick #9802 to 6.6: Remove X-Pack foo Metricbeat module Cherry-pick #9802 to 6.6: Remove X-Pack foo Metricbeat module from reference file Dec 28, 2018
@sayden sayden self-assigned this Dec 28, 2018
@sayden
Copy link
Contributor Author

sayden commented Jan 2, 2019

Error seems unrelated

@sayden sayden merged commit 14dcb2f into elastic:6.6 Jan 2, 2019
@sayden sayden deleted the backport_9802_6.6 branch October 29, 2021 08:56
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ml file (elastic#9802) (elastic#9804)

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. A small reference on the `metricbeat.reference.yml` is removed as it seems that we forgot it there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants