-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove X-Pack foo Metricbeat module #9802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayden
added
review
Metricbeat
Metricbeat
needs_backport
PR is waiting to be backported to other branches.
labels
Dec 27, 2018
ruflin
approved these changes
Dec 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For the metricbeat.reference.yml file update: Did you have to do this change manually or is mage update
taking care of this?
|
sayden
added a commit
to sayden/beats
that referenced
this pull request
Dec 27, 2018
The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. After merging MS SQL module in X-Pack, we can already remove this dummy module.
sayden
added
v6.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Dec 27, 2018
sayden
added a commit
to sayden/beats
that referenced
this pull request
Dec 27, 2018
The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. After merging MS SQL module in X-Pack, we can already remove this dummy module.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ml file (elastic#9802) (elastic#9804) The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. A small reference on the `metricbeat.reference.yml` is removed as it seems that we forgot it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the
foo
module in Metricbeat X-Pack was to test the new build and test system within thex-pack/metricbeat
folder.After merging MS SQL module in X-Pack, we can already remove this dummy module.
Things that have been removed:
module/foo
include/list.go
filemetricbeat.reference.yml
file.