Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X-Pack foo Metricbeat module #9802

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Dec 27, 2018

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder.

After merging MS SQL module in X-Pack, we can already remove this dummy module.

Things that have been removed:

  • module folder and all its contents module/foo
  • References to the module and metricset in include/list.go file
  • Reference in the metricbeat.reference.yml file.

@sayden sayden added review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. labels Dec 27, 2018
@sayden sayden self-assigned this Dec 27, 2018
@sayden sayden requested a review from ruflin December 27, 2018 11:55
@sayden sayden requested a review from a team as a code owner December 27, 2018 11:55
@sayden sayden changed the title Remove X-Pack foo module Remove X-Pack foo Metricbeat module Dec 27, 2018
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the metricbeat.reference.yml file update: Did you have to do this change manually or is mage update taking care of this?

@sayden
Copy link
Contributor Author

sayden commented Dec 27, 2018

mage update did the trick 😉

@sayden sayden merged commit ecb3189 into elastic:master Dec 27, 2018
sayden added a commit to sayden/beats that referenced this pull request Dec 27, 2018
The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder.

After merging MS SQL module in X-Pack, we can already remove this dummy module.
@sayden sayden added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 27, 2018
sayden added a commit to sayden/beats that referenced this pull request Dec 27, 2018
The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder.

After merging MS SQL module in X-Pack, we can already remove this dummy module.
@sayden sayden added the v6.6.0 label Dec 27, 2018
sayden added a commit that referenced this pull request Jan 2, 2019
…ml file (#9802) (#9804)

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. A small reference on the `metricbeat.reference.yml` is removed as it seems that we forgot it there.
sayden added a commit that referenced this pull request Jan 2, 2019
…ml file (#9802) (#9803)

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. A small reference on the `metricbeat.reference.yml` is removed as it seems that we forgot it there.
@sayden sayden deleted the xp/remove-foo-module branch August 25, 2022 12:50
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ml file (elastic#9802) (elastic#9804)

The purpose of the foo module in Metricbeat X-Pack was to test the new build and test system within the x-pack/metricbeat folder. A small reference on the `metricbeat.reference.yml` is removed as it seems that we forgot it there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants