-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[heartbeat] Remove script / make task for generating monitors #9648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
enhancement
review
Heartbeat
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
labels
Dec 18, 2018
Pinging @elastic/uptime |
This was rarely used, and already out of date. We've discussed this in elastic#9132 and decided it's not worth maintaining. Fixes elastic#9132
andrewvc
force-pushed
the
remove-hb-generator-script
branch
from
December 18, 2018 22:30
c721544
to
c45acae
Compare
andrewvc
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Dec 18, 2018
ruflin
approved these changes
Dec 19, 2018
Test failures unrelated. (looks like we aren't blocking on flaky tests anymore, but rather waiting for pipelines) |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Dec 20, 2018
…c#9648) This was rarely used, and already out of date. We've discussed this in elastic#9132 and decided it's not worth maintaining. Fixes elastic#9132 (cherry picked from commit 2784b84)
andrewvc
added
v6.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Dec 20, 2018
andrewvc
added a commit
that referenced
this pull request
Dec 20, 2018
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 12, 2019
In elastic#9648 the monitor generator script was removed, but its supporting files were not. This commit removes the remaining legacy files.
andrewvc
added a commit
that referenced
this pull request
Mar 16, 2019
In #9648 the monitor generator script was removed, but its supporting files were not. This commit removes the remaining legacy files.
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 16, 2019
In elastic#9648 the monitor generator script was removed, but its supporting files were not. This commit removes the remaining legacy files. (cherry picked from commit 005bb60)
This was referenced Mar 16, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 16, 2019
In elastic#9648 the monitor generator script was removed, but its supporting files were not. This commit removes the remaining legacy files. (cherry picked from commit 005bb60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Heartbeat
review
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
v6.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was rarely used, and already out of date. We've discussed this in #9132 and decided it's not worth maintaining.