Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Heartbeat Monitor Generation Script #9132

Closed
andrewvc opened this issue Nov 16, 2018 · 6 comments
Closed

Remove Heartbeat Monitor Generation Script #9132

andrewvc opened this issue Nov 16, 2018 · 6 comments
Assignees
Labels
discuss Issue needs further discussion. enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Nov 16, 2018

In #9090 @xu001186 reported that our generator for monitors broke with some internal changes.

This is a seldom used feature, and probably not worth the maintenance burden to document. I propose that we remove all generators for now.

To solve the general problem of users performing custom checks I would propose that we come up with a solution that doesn't require forking / recompilation. Instead we could do something like Nagios' NPAPI, where we invoke a process and use stdin/stdout to check the status of the monitor.

@andrewvc andrewvc added enhancement discuss Issue needs further discussion. Heartbeat labels Nov 16, 2018
@ruflin
Copy link
Contributor

ruflin commented Nov 19, 2018

Sounds a lot like the exec module we have been discussing for a while (@exekias ).

@andrewvc
Copy link
Contributor Author

I'm realizing that there are two parts to this issue:

  1. Is maintaining the monitor generator worth it?
  2. Should we make an exec thing.

I'd like us to answer those separately if possible. I think we can remove the generator script without a replacement for now.

@ruflin
Copy link
Contributor

ruflin commented Nov 20, 2018

+1 on removing the generator script.

@alvarolobato alvarolobato added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Nov 21, 2018
@xu001186
Copy link

Before the new monitor plugin is introduced, it might be a good idea to keep the old template.
Anyway, I created a shell plugin based on the old template.

@ruflin ruflin added Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Dec 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime

andrewvc added a commit to andrewvc/beats that referenced this issue Dec 18, 2018
This was rarely used, and already out of date. We've discussed this in elastic#9132 and decided it's not worth maintaining.

Fixes elastic#9132
@andrewvc
Copy link
Contributor Author

@xu001186 is your shell plugin open source? It'd be awesome to check it out!

andrewvc added a commit to andrewvc/beats that referenced this issue Dec 20, 2018
…c#9648)

This was rarely used, and already out of date. We've discussed this in elastic#9132 and decided it's not worth maintaining.

Fixes elastic#9132

(cherry picked from commit 2784b84)
andrewvc added a commit that referenced this issue Dec 20, 2018
…#9698)

This was rarely used, and already out of date. We've discussed this in #9132 and decided it's not worth maintaining.

Fixes #9132

(cherry picked from commit 2784b84)
@alvarolobato alvarolobato reopened this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

No branches or pull requests

5 participants