-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Heartbeat Monitor Generation Script #9132
Comments
Sounds a lot like the |
I'm realizing that there are two parts to this issue:
I'd like us to answer those separately if possible. I think we can remove the generator script without a replacement for now. |
+1 on removing the generator script. |
Before the new monitor plugin is introduced, it might be a good idea to keep the old template. |
Pinging @elastic/uptime |
This was rarely used, and already out of date. We've discussed this in elastic#9132 and decided it's not worth maintaining. Fixes elastic#9132
@xu001186 is your shell plugin open source? It'd be awesome to check it out! |
…c#9648) This was rarely used, and already out of date. We've discussed this in elastic#9132 and decided it's not worth maintaining. Fixes elastic#9132 (cherry picked from commit 2784b84)
In #9090 @xu001186 reported that our generator for monitors broke with some internal changes.
This is a seldom used feature, and probably not worth the maintenance burden to document. I propose that we remove all generators for now.
To solve the general problem of users performing custom checks I would propose that we come up with a solution that doesn't require forking / recompilation. Instead we could do something like Nagios' NPAPI, where we invoke a process and use stdin/stdout to check the status of the monitor.
The text was updated successfully, but these errors were encountered: