Cherry-pick #7553 to 6.3: Bring back support for really old Docker versions #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542 (cherry picked from commit 2215d24)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…cker versions (elastic#7567) Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542 (cherry picked from commit cecb9a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7553 to 6.3 branch. Original message:
Introducing API version negotiation (#7165) brough support for new
Docker versions, but broke support for versions in EOL.
This change puts old API version (1.22) back on the default fallback,
plus introduces version hardcoding through
DOCKER_API_VERSIONenvironment variable.
I added some integration tests to check things are working.
Fixes #7542