Bring back support for really old Docker versions #7553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
enhancement
review
libbeat
needs_backport
Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542
exekias
force-pushed
the
support-older-dockers
branch
from
036b3c9 to
c8d91cd
Compare
ruflin
reviewed
Jul 10, 2018
| if ping.APIVersion == "" { | ||
| ping.APIVersion = "1.24" | ||
| } | ||
| if os.Getenv("DOCKER_API_VERSION") == "" { |
There was a problem hiding this comment.
Is DOCKER_API_VERSION set by default? If not it seems this code is always called also for a newer version?
There was a problem hiding this comment.
DOCKER_API_VERSION is used to hardcode client API version. If it's unset (which is common), beats should negotiate client API version to ensure we use one compatible with the server
|
I think we will also need some docs around this to explain users they can use |
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jul 11, 2018
Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542 (cherry picked from commit 2215d24)
exekias
added
v6.3.2
and removed
needs_backport
ruflin
pushed a commit
that referenced
this pull request
Jul 12, 2018
…rsions (#7567) Introducing API version negotiation (#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes #7542 (cherry picked from commit 2215d24)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…cker versions (elastic#7567) Introducing API version negotiation (elastic#7165) brough support for new Docker versions, but broke support for versions in EOL. This change puts old API version (1.229 back on the default fallback, plus introduces version hardcoding through `DOCKER_API_VERSION` environment variable. I added some integration tests to check things are working. Fixes elastic#7542 (cherry picked from commit cecb9a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing API version negotiation (#7165) brough support for new
Docker versions, but broke support for versions in EOL.
This change puts old API version (1.22) back on the default fallback,
plus introduces version hardcoding through
DOCKER_API_VERSIONenvironment variable.
I added some integration tests to check things are working.
Fixes #7542