Cherry-pick #7235 to 6.3: Don't emit Kubernetes autodiscover events without host #7289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this fix is important, without this failing runners in metricbeat are never removed, what may lead to leaks and misleading log messages (like the ones in #7194). We may want to have it already in 6.3.0 as it affects Kubernetes autodiscover hints. I have done some manual testing of 6.3 branch with this patch and it works fine. |
exekias
force-pushed
the
backport_7235_6.3
branch
from
32f5f84 to
f4f1a7b
Compare
Some kubernetes events are generated while the container is being configured. It doesn't make sense to emit an event yet, as the host will be update right afterwards. This PR changes the code to ignore Pod events without an IP address. (cherry picked from commit 7b5a7e4)
exekias
force-pushed
the
backport_7235_6.3
branch
from
f4f1a7b to
7a3934c
Compare
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#7289) Some kubernetes events are generated while the container is being configured. It doesn't make sense to emit an event yet, as the host will be update right afterwards. This PR changes the code to ignore Pod events without an IP address. (cherry picked from commit 65c8c03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7235 to 6.3 branch. Original message:
Some kubernetes events are generated while the container is being
configured. It doesn't make sense to emit an event yet, as the host will
be update right afterwards.
This PR changes the code to ignore Pod events without an IP address.
Closes #7193