Don't emit Kubernetes autodiscover events without host #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
enhancement
in progress
|
Change LGTM. Don't merge yet as still |
exekias
force-pushed
the
k8s-no-host-events
branch
from
347910b to
5ee7de7
Compare
Some kubernetes events are generated while the container is being configured. It doesn't make sense to emit an event yet, as the host will be update right afterwards. This PR changes the code to ignore Pod events without an IP address.
exekias
force-pushed
the
k8s-no-host-events
branch
from
5ee7de7 to
32e9e66
Compare
|
Added tests and changelog |
exekias
added
review
and removed
in progress
exekias
added
needs_backport
exekias
added
v6.3.0
and removed
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jun 8, 2018
Some kubernetes events are generated while the container is being configured. It doesn't make sense to emit an event yet, as the host will be update right afterwards. This PR changes the code to ignore Pod events without an IP address. (cherry picked from commit 7b5a7e4)
jsoriano
pushed a commit
that referenced
this pull request
Jun 8, 2018
Some kubernetes events are generated while the container is being configured. It doesn't make sense to emit an event yet, as the host will be update right afterwards. This PR changes the code to ignore Pod events without an IP address. (cherry picked from commit 7b5a7e4)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#7289) Some kubernetes events are generated while the container is being configured. It doesn't make sense to emit an event yet, as the host will be update right afterwards. This PR changes the code to ignore Pod events without an IP address. (cherry picked from commit 65c8c03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some kubernetes events are generated while the container is being
configured. It doesn't make sense to emit an event yet, as the host will
be update right afterwards.
This PR changes the code to ignore Pod events without an IP address.
Closes #7193