Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump elastic stack tests to 6.2.2 #6370

Merged
merged 2 commits into from
Feb 13, 2018
Merged

bump elastic stack tests to 6.2.2 #6370

merged 2 commits into from
Feb 13, 2018

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Feb 13, 2018

Tests are failing since the update to 6.2.2 - 6.2.1-SNAPSHOT is no longer available. The kibana tests are failing too though I can't tell why - the url hit for the snapshot seems valid - should those be on 6.2.2 in the 6.2 branch anyway?

@graphaelli
Copy link
Member Author

seems better than where this started - all containers are built and the tests run but just this one in FB fails:

10:56:39 ======================================================================
10:56:39 FAIL: Tests all filebeat modules
10:56:39 ----------------------------------------------------------------------
10:56:39 Traceback (most recent call last):
10:56:39   File "/go/src/github.com/elastic/beats/filebeat/tests/system/test_modules.py", line 71, in test_modules
10:56:39     cfgfile=cfgfile)
10:56:39   File "/go/src/github.com/elastic/beats/filebeat/tests/system/test_modules.py", line 151, in run_on_file
10:56:39     self._test_expected_events(module, test_file, res, objects)
10:56:39   File "/go/src/github.com/elastic/beats/filebeat/tests/system/test_modules.py", line 94, in _test_expected_events
10:56:39     ev["_source"][module], objects)
10:56:39 AssertionError: The following expected object was not found:
10:56:39  {u'slowlog': {u'took_in_millis': 3027, u'level': u'WARN', u'took_in_nanos': 3027675140.0, u'plugin_name': u'sleep', u'module': u'slowlog.logstash.filters.sleep', u'message': u'event processing time {:plugin_params=>{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}, :took_in_nanos=>3027675106, :took_in_millis=>3027, :event=>"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"}', u'plugin_params': u'{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}', u'event': u'"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"', u'plugin_type': u'filters'}}
10:56:39 Searched in: 
10:56:39 [{u'beat': {u'hostname': u'96513e2090f7', u'name': u'96513e2090f7', u'version': u'6.2.2'}, u'@timestamp': u'2017-10-30T09:57:58,243', u'read_timestamp': u'2018-02-13T15:54:41.791Z', u'fileset': {u'name': u'slowlog', u'module': u'logstash'}, u'prospector': {u'type': u'log'}, u'source': u'/go/src/github.com/elastic/beats/filebeat/module/logstash/slowlog/test/slowlog-plain.log', u'offset': 383, u'logstash': {u'slowlog': {u'took_in_millis': 3027, u'level': u'WARN', u'took_in_nanos': 3027675106, u'module': u'slowlog.logstash.filters.sleep', u'plugin_name': u'sleep', u'message': u'event processing time {:plugin_params=>{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}, :took_in_nanos=>3027675106, :took_in_millis=>3027, :event=>"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"}', u'plugin_params': u'{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}', u'event': u'"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"', u'plugin_type': u'filters'}}}]

@ph
Copy link
Contributor

ph commented Feb 13, 2018

I will backport this #6318 this should fix the problem you are currently having.

@graphaelli
Copy link
Member Author

@ph thanks! I'll rebase afterwards

ph and others added 2 commits February 13, 2018 14:02
We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: elastic#6317
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph
Copy link
Contributor

ph commented Feb 13, 2018

The failing test looks more like a timing issue I will merge this.

@ph ph merged commit 7dd818f into elastic:6.2 Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants