Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logstash filebeat module test failling #6317

Closed
ph opened this issue Feb 7, 2018 · 1 comment
Closed

Logstash filebeat module test failling #6317

ph opened this issue Feb 7, 2018 · 1 comment
Assignees
@ph
Labels
bug Filebeat Filebeat

Comments

@ph
Copy link
Contributor

ph commented Feb 7, 2018 •
edited
Loading

The current test for the logstash slowlog module is currently failling on the master branch, the document generated from the ingest pipeline doesn't match the expected values (expect int got float). The numbers doesn't match.

{   u'slowlog': {   u'event': u'"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"',
                    u'level': u'WARN',
                    u'message': u'event processing time {:plugin_params=>{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}, :took_in_nanos=>3027675106, :took_in_millis=>3027, :event=>"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"}',
                    u'module': u'slowlog.logstash.filters.sleep',
                    u'plugin_name': u'sleep',
                    u'plugin_params': u'{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}',
                    u'plugin_type': u'filters',
                    u'took_in_millis': 3027,
                    u'took_in_nanos': 3027675140.0}}
{   u'slowlog': {   u'event': u'"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"',
                    u'level': u'WARN',
                    u'message': u'event processing time {:plugin_params=>{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}, :took_in_nanos=>3027675106, :took_in_millis=>3027, :event=>"{\\"@version\\":\\"1\\",\\"@timestamp\\":\\"2017-10-30T13:57:55.130Z\\",\\"host\\":\\"sashimi\\",\\"sequence\\":0,\\"message\\":\\"Hello world!\\"}"}',
                    u'module': u'slowlog.logstash.filters.sleep',
                    u'plugin_name': u'sleep',
                    u'plugin_params': u'{"time"=>3, "id"=>"e4e12a4e3082615c5427079bf4250dbfa338ebac10f8ea9912d7b98a14f56b8c"}',
                    u'plugin_type': u'filters',
                    u'took_in_millis': 3027,
                    u'took_in_nanos': 3027675106}}
@ph ph added bug Filebeat Filebeat labels Feb 7, 2018
@ph ph self-assigned this Feb 7, 2018
@ph
Copy link
Contributor Author

ph commented Feb 7, 2018 •
edited
Loading

notes this test works with ES 6.1.2 but not in 6.2.0

ph added a commit to ph/beats that referenced this issue Feb 7, 2018
@ph
Wrong assertions and types conversion on the logstash slow plain format.
b7aeec3 
We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: elastic#6317
@ph ph mentioned this issue Feb 7, 2018
Merged
exekias pushed a commit that referenced this issue Feb 8, 2018
@ph @exekias
Wrong assertions and types conversion on the logstash slow plain form…
6fe02a4 
…at. (#6318)

Wrong assertions and types conversion on the logstash slow plain format.

We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: #6317
ph added a commit to ph/beats that referenced this issue Feb 13, 2018
@ph
Wrong assertions and types conversion on the logstash slow plain format.
840517a 
We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: elastic#6317
@ph ph mentioned this issue Feb 13, 2018
Closed
ph added a commit that referenced this issue Feb 13, 2018
@ph
Wrong assertions and types conversion on the logstash slow plain format.
a962bf9 
We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: #6317
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@ph
Wrong assertions and types conversion on the logstash slow plain format.
19d5045 
We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: elastic#6317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ph ph

Labels
bug Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ph