Fix leaking go routine in docker stats fetching (#3492) #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
reviewed
Feb 2, 2017
CHANGELOG.asciidoc
Outdated
| @@ -87,6 +87,8 @@ https://github.com/elastic/beats/compare/v5.1.2...v5.2.0[View commits] | |||
| - Fix service times-out at startup. {pull}3056[3056] | |||
| - Kafka module case sensitive host name matching. {pull}3193[3193] | |||
| - Fix interface conversion panic in couchbase module {pull}3272[3272] | |||
| - Fix overwriting explicit empty config sections {issue}2918[2918] | |||
| - Fix go routine leak in docker module. {pull}3492[3492] | |||
There was a problem hiding this comment.
Can you cleanup the Changelog in this PR, please? It looks like the cherry-pick added two lines and to the 5.2.0 header. I'm afraid that if we'll merge it like this, we're going to forget to fix one of these two issues.
Go routine on line 79 never stopped as queue was not closed. Fixes elastic#3489 (cherry picked from commit 3366bdb)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#3514) Go routine on line 79 never stopped as queue was not closed. Fixes elastic#3489 (cherry picked from commit 4e615a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go routine on line 79 never stopped as queue was not closed.
Fixes #3489
(cherry picked from commit 3366bdb)