Fix leaking go routine in docker stats fetching (#3492)

CHANGELOG.asciidoc

@@ -8,7 +8,7 @@
 // Template, add newest changes here
 
 === Beats version HEAD
-https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff]
+https://github.com/elastic/beats/compare/v5.2.0...master[Check the HEAD diff]
 
 ==== Breaking changes
 
@@ -33,6 +33,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff]
 *Heartbeat*
 
 *Metricbeat*
+- Fix go routine leak in docker module. {pull}3492[3492]
 
 *Packetbeat*
 

metricbeat/module/docker/docker.go

@@ -66,24 +66,26 @@ func FetchStats(client *docker.Client) ([]Stat, error) {
 
 	var wg sync.WaitGroup
 
-	containersList := []Stat{}
+	containersList := make([]Stat, 0, len(containers))
 	queue := make(chan Stat, 1)
 	wg.Add(len(containers))
 
 	for _, container := range containers {
 		go func(container docker.APIContainers) {
+			defer wg.Done()
 			queue <- exportContainerStats(client, &container)
 		}(container)
 	}
 
 	go func() {
-		for container := range queue {
-			containersList = append(containersList, container)
-			wg.Done()
-		}
+		wg.Wait()
+		close(queue)
 	}()
 
-	wg.Wait()
+	// This will break after the queue has been drained and queue is closed.
+	for container := range queue {
+		containersList = append(containersList, container)
+	}
 
 	return containersList, err
 }