Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add procs running #33614

Merged
merged 7 commits into from
Nov 11, 2022
Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

Closes #31074

This adds a little subsection to the system_summary metricset with data on individual threads extracted from /proc/stat

I was a little unsure of where to put this, since it's such a small change that isn't really needed by anything else, so I figured it wasn't worth it to throw it in a separate library somewhere.

Why is it important?

Some users want per-thread metrics, see original issue.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added Team:Elastic-Agent Label for the Agent team v8.6.0 labels Nov 8, 2022
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner November 8, 2022 20:14
@fearful-symmetry fearful-symmetry self-assigned this Nov 8, 2022
@fearful-symmetry fearful-symmetry requested review from belimawr and faec and removed request for a team November 8, 2022 20:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-09T16:57:13.442+0000

  • Duration: 50 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 3895
Skipped 889
Total 4784

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@fearful-symmetry
Copy link
Contributor Author

Github CI lint errors are unfixable; the github runner can't compile with cgo, so it's failing on files that import something with cgo.

@fearful-symmetry fearful-symmetry merged commit 69880a3 into elastic:main Nov 11, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* start adding thread counts

* finish adding thread metrics to process_summary

* add changelog

* fix test

* fix CI

* still fixing CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture procs_running threads with metricbeat
3 participants