Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat system module - collect total thread count #34461

Closed
nimarezainia opened this issue Feb 2, 2023 · 2 comments · Fixed by #36578
Closed

Metricbeat system module - collect total thread count #34461

nimarezainia opened this issue Feb 2, 2023 · 2 comments · Fixed by #36578
Assignees
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@nimarezainia
Copy link
Contributor

nimarezainia commented Feb 2, 2023

We are exploring the use of Metricbeat to monitor our core servers and while we do like how it all comes together (especially with Kibana's dashboards) we've noticed that metricbeat is not collecting all the metrics we require

The missing metric is total number of threads. This metric is an important one for our Operational Team to monitor, so would be great to know if there are plans for Metricbeat to collect it as part of system (or any other module) module?

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Feb 2, 2023
@cmacknz cmacknz transferred this issue from elastic/elastic-agent Feb 2, 2023
@pierrehilbert pierrehilbert assigned AndersonQ and unassigned belimawr Mar 1, 2023
@AndersonQ
Copy link
Member

AndersonQ commented Jul 28, 2023

@nimarezainia after looking at the info here and in the enhancement request, I'd like to confirm if I'm understanding the scope correctly.

  • collect the total thread count per process
  • OS must have: linux
  • OS nice to have: mac, windows
  • do we need for containers and Kubernetes as well?

do we want to deliver it "per platform", that means a PR per platform, thus delivering value quicker or rather have a big PR with all possible platforms?

cc: @pierrehilbert

@nimarezainia
Copy link
Contributor Author

@nimarezainia after looking at the info here and in the enhancement request, I'd like to confirm if I'm understanding the scope correctly.

* collect the `total thread count` **per process**

* OS must have: linux

* OS nice to have: mac, windows

* do we need for containers and Kubernetes as well?

do we want to deliver it "per platform", that means a PR per platform, thus delivering value quicker or rather have a big PR with all possible platforms?

cc: @pierrehilbert

thx @AndersonQ.

The scope:

  • "total thread count per process" correct. the original fix was Add procs running #33614 which just addressed the total thread count.
  • Should be applied everywhere so we are consistent across the board (again similar to the original fix)
  • I don't think a PR per platform makes sense unless there are testing considerations that I am unaware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants