Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: run check, check-default and pre-commit #32723

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 17, 2022

What does this PR do?

Use GitHub actions to run the check stage default commands for:

  • only docs
  • everytime
  • pre-commit

On a PR basis

Why is it important?

Faster build by running linting/checks outside of the main CI Pipeline.

Issue

Similar to #32711

Failures

libsystemd-dev is required otherwise

Error: ../../../../go/pkg/mod/github.com/coreos/go-systemd/[email protected]/sdjournal/journal.go:27:11: fatal error: systemd/sd-journal.h: No such file or directory
   27 | // #include <systemd/sd-journal.h>
      |           ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Error: failed running go vet, please fix the issues reported: running "go vet ./..." failed with exit code 2

librpmlib-dev is required otherwise

# github.com/elastic/beats/v7/x-pack/auditbeat/module/system/package
Error: module/system/package/rpm_linux.go:26:10: fatal error: rpm/rpmlib.h: No such file or directory
   26 | #include <rpm/rpmlib.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
# github.com/elastic/beats/v7/x-pack/auditbeat/module/system/package
Error: module/system/package/rpm_linux.go:26:10: fatal error: rpm/rpmlib.h: No such file or directory
   26 | #include <rpm/rpmlib.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
Error: failed running go vet, please fix the issues reported: running "go vet ./..." failed with exit code 2
make[1]: *** [../../dev-tools/make/mage.mk:21: check] Error 1

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)
    To fixup this pull request, you need to add the backport labels for the needed
    branches, such as:
  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned v1v Aug 17, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 17, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-18T11:05:46.720+0000

  • Duration: 87 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 22617
Skipped 1937
Total 24554

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v requested a review from a team August 18, 2022 11:05
@v1v v1v added automation Team:Automation Label for the Observability productivity team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify labels Aug 18, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 18, 2022
@v1v v1v marked this pull request as ready for review August 18, 2022 11:06
@v1v v1v requested a review from a team as a code owner August 18, 2022 11:06
@v1v v1v requested review from cmacknz and faec and removed request for a team August 18, 2022 11:06
@v1v v1v merged commit 1fa3f3d into elastic:main Aug 22, 2022
mergify bot pushed a commit that referenced this pull request Aug 22, 2022
(cherry picked from commit 1fa3f3d)

# Conflicts:
#	Jenkinsfile
mergify bot pushed a commit that referenced this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants