Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat]: limit parallelization of tasks by jobtype #27160

Merged
merged 6 commits into from
Aug 11, 2021

Conversation

vigneshshanmugam
Copy link
Member

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2021
@vigneshshanmugam vigneshshanmugam added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jul 30, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-10T22:33:49.438+0000

  • Duration: 62 min 53 sec

  • Commit: 10b8306

Test stats 🧪

Test Results
Failed 0
Passed 3388
Skipped 80
Total 3468

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3388
Skipped 80
Total 3468

@vigneshshanmugam vigneshshanmugam marked this pull request as ready for review July 30, 2021 22:59
@vigneshshanmugam vigneshshanmugam requested a review from a team as a code owner July 30, 2021 22:59
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, needs a couple minor changes

heartbeat/scheduler/scheduler.go Outdated Show resolved Hide resolved
heartbeat/scheduler/scheduler_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Copy link
Contributor

/test

@vigneshshanmugam vigneshshanmugam added the backport-v7.15.0 Automated backport with mergify label Aug 11, 2021
@vigneshshanmugam vigneshshanmugam merged commit 70402c6 into elastic:master Aug 11, 2021
@vigneshshanmugam vigneshshanmugam deleted the limit-scheduler branch August 11, 2021 05:20
mergify bot pushed a commit that referenced this pull request Aug 11, 2021
* [Heartbeat]: limit parallelization of tasks by jobtype

* handle release and add tests

* fix linting

* add guard aganist nil in tests

* address review comments

* add test when limit is not specified

(cherry picked from commit 70402c6)
vigneshshanmugam added a commit that referenced this pull request Aug 11, 2021
* [Heartbeat]: limit parallelization of tasks by jobtype

* handle release and add tests

* fix linting

* add guard aganist nil in tests

* address review comments

* add test when limit is not specified

(cherry picked from commit 70402c6)

Co-authored-by: Vignesh Shanmugam <[email protected]>
@andrewvc andrewvc added the test-plan Add this PR to be manual test plan label Aug 18, 2021
mergify bot pushed a commit that referenced this pull request Aug 18, 2021
* [Heartbeat]: limit parallelization of tasks by jobtype

* handle release and add tests

* fix linting

* add guard aganist nil in tests

* address review comments

* add test when limit is not specified

(cherry picked from commit 70402c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan Add this PR to be manual test plan v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Limit number of parallel monitors, by type
3 participants