Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Limit number of parallel monitors, by type #23216

Closed
andrewvc opened this issue Dec 18, 2020 · 2 comments · Fixed by #27160
Closed

[Heartbeat] Limit number of parallel monitors, by type #23216

andrewvc opened this issue Dec 18, 2020 · 2 comments · Fixed by #27160
Assignees
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.15.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Dec 18, 2020

Today, heartbeat has the heartbeat.scheduler.limit option, which limits the total number of internal tasks heartbeat can run. For lightweight checks this corresponds to the number of open file descriptors.

This doesn't work well for synthetics, where each check is made of a single recursive run of many tasks (one per JSON line from the agent) that don't correlate to FDs at all.

We should add a new setting:

heartbeat.jobs.{icmp|http|tcp|browser}.limit which lets users define on a job-type basis how many concurrent tasks may be run.

Docs are updated to clarify how these relate and should be used

@andrewvc andrewvc added enhancement Heartbeat [zube]: Ready Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Dec 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@vigneshshanmugam vigneshshanmugam removed the refined Issue refined, ready to work on label Aug 18, 2021
@dominiqueclarke dominiqueclarke self-assigned this Aug 24, 2021
@dominiqueclarke dominiqueclarke added the test-plan-ok This PR passed manual testing label Aug 25, 2021
@dominiqueclarke
Copy link

Working as expected for icmp, tcp, http, and browser monitors in 7.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.15.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants