-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osquerybeat: Change the query timeout from 3 secs to 60 secs #26775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The 3 seconds timeout was too low for wifi_survey query for example which was taking more like 5 seconds on the test box. Bumping the value up eliminited timeouts.
aleksmaus
added
bug
backport-v7.14.0
Automated backport with mergify
Team:Asset Mgt
backport-v7.15.0
Automated backport with mergify
labels
Jul 7, 2021
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 7, 2021
james-elastic
approved these changes
Jul 7, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
* The 3 seconds timeout was too low for wifi_survey query for example which was taking more like 5 seconds on the test box. Bumping the value up eliminited timeouts. (cherry picked from commit 1754f54)
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
* The 3 seconds timeout was too low for wifi_survey query for example which was taking more like 5 seconds on the test box. Bumping the value up eliminited timeouts. (cherry picked from commit 1754f54)
aleksmaus
added a commit
that referenced
this pull request
Jul 7, 2021
…#26778) * The 3 seconds timeout was too low for wifi_survey query for example which was taking more like 5 seconds on the test box. Bumping the value up eliminited timeouts. (cherry picked from commit 1754f54) Co-authored-by: Aleksandr Maus <[email protected]>
aleksmaus
added a commit
that referenced
this pull request
Jul 7, 2021
…#26779) * The 3 seconds timeout was too low for wifi_survey query for example which was taking more like 5 seconds on the test box. Bumping the value up eliminited timeouts. (cherry picked from commit 1754f54) Co-authored-by: Aleksandr Maus <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 8, 2021
* upstream/master: (430 commits) CI: increase timeout (elastic#26764) Heartbeat: add datastream fields to synthetics (elastic#26774) Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775) Remove experimental warning for inputs with variables. (elastic#26762) Add latest k8s versions in testing (elastic#26729) change type of max_bytes to ByteType (elastic#26699) [Elastic Agent] Fix broken enrollment command (elastic#26749) Update agent managed manifest to include enrolment token variable (elastic#26756) Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737) Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754) Upgrade PyYAML dependency used for tests (elastic#26746) Add agent fleet enrolment k8s manifest (elastic#26566) CI: retry the step only (elastic#26736) Osquerybeat: Fix the configuration poll interval setting (elastic#26739) [Filebeat] Replace copy_from with templated value (elastic#26631) Reduce the verbosity of the debug log for monitoring (elastic#26583) Add instructions on testing metricbeat kubernetes module (elastic#26643) Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704) Packaging: linux/armv7 is not supported (elastic#26706) Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v7.14.0
Automated backport with mergify
backport-v7.15.0
Automated backport with mergify
bug
Team:Asset Mgt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase osquery timeout from 3 secs to 60 secs. The 3 seconds timeout was too low for
wifi_survey
table query for example which was taking more like 5 seconds on the test box if running standalone with osqueryi. Bumping the value up eliminated timeouts.Why is it important?
Some queries will timeout on slower machines, 3 secs timeout was not enough.
Checklist
Related issues
Screenshots
Validated the
wifi_survey
table query completes successfully after the change: