Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the verbosity of the debug log for monitoring #26583

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

ph
Copy link
Contributor

@ph ph commented Jun 29, 2021

Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.

We can receive the same information by running the inspect subcommand
this require access to the local machine and the necessary privileges to
read the files.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph ph added review Team:Elastic-Agent Label for the Agent team labels Jun 29, 2021
@ph ph requested a review from michalpristas June 29, 2021 17:58
@ph ph self-assigned this Jun 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 29, 2021
@ph ph added the backport-v7.14.0 Automated backport with mergify label Jun 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26583 updated

  • Start Time: 2021-07-05T15:57:12.871+0000

  • Duration: 70 min 26 sec

  • Commit: d6c6db5

Test stats 🧪

Test Results
Failed 0
Passed 6972
Skipped 16
Total 6988

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6972
Skipped 16
Total 6988

@ph
Copy link
Contributor Author

ph commented Jun 29, 2021

Seems to be a CI error.. will retrigger.

@ph
Copy link
Contributor Author

ph commented Jun 29, 2021

/test

ph added 2 commits June 29, 2021 15:27
Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.

We can receive the same information by running the `inspect` subcommand
this require access to the local machine and the necessary privileges to
read the files.
@ph ph force-pushed the remove-debug-log-for-monitoring branch from 1c3004d to e75964c Compare June 29, 2021 19:27
@blakerouse blakerouse added the backport-v7.15.0 Automated backport with mergify label Jul 1, 2021
@michel-laterman michel-laterman self-assigned this Jul 5, 2021
@michel-laterman michel-laterman merged commit c3925fc into elastic:master Jul 5, 2021
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring

Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.

We can receive the same information by running the `inspect` subcommand
this require access to the local machine and the necessary privileges to
read the files.

* Changelog

* Add PR number, run make check

Co-authored-by: michel-laterman <[email protected]>
(cherry picked from commit c3925fc)
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring

Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.

We can receive the same information by running the `inspect` subcommand
this require access to the local machine and the necessary privileges to
read the files.

* Changelog

* Add PR number, run make check

Co-authored-by: michel-laterman <[email protected]>
(cherry picked from commit c3925fc)
michel-laterman pushed a commit that referenced this pull request Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring

Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.

We can receive the same information by running the `inspect` subcommand
this require access to the local machine and the necessary privileges to
read the files.

* Changelog

* Add PR number, run make check

Co-authored-by: michel-laterman <[email protected]>
(cherry picked from commit c3925fc)

Co-authored-by: Pier-Hugues Pellerin <[email protected]>
michel-laterman pushed a commit that referenced this pull request Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring

Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.

We can receive the same information by running the `inspect` subcommand
this require access to the local machine and the necessary privileges to
read the files.

* Changelog

* Add PR number, run make check

Co-authored-by: michel-laterman <[email protected]>
(cherry picked from commit c3925fc)

Co-authored-by: Pier-Hugues Pellerin <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Jul 8, 2021
* upstream/master: (430 commits)
  CI: increase timeout (elastic#26764)
  Heartbeat: add datastream fields to synthetics (elastic#26774)
  Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775)
  Remove experimental warning for inputs with variables. (elastic#26762)
  Add latest k8s versions in testing (elastic#26729)
  change type of max_bytes to ByteType (elastic#26699)
  [Elastic Agent] Fix broken enrollment command (elastic#26749)
  Update agent managed manifest to include enrolment token variable (elastic#26756)
  Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737)
  Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754)
  Upgrade PyYAML dependency used for tests (elastic#26746)
  Add agent fleet enrolment k8s manifest (elastic#26566)
  CI: retry the step only (elastic#26736)
  Osquerybeat: Fix the configuration poll interval setting (elastic#26739)
  [Filebeat] Replace copy_from with templated value (elastic#26631)
  Reduce the verbosity of the debug log for monitoring (elastic#26583)
  Add instructions on testing metricbeat kubernetes module (elastic#26643)
  Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704)
  Packaging: linux/armv7 is not supported (elastic#26706)
  Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify review Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants