-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the verbosity of the debug log for monitoring #26583
Merged
michel-laterman
merged 3 commits into
elastic:master
from
ph:remove-debug-log-for-monitoring
Jul 5, 2021
Merged
Reduce the verbosity of the debug log for monitoring #26583
michel-laterman
merged 3 commits into
elastic:master
from
ph:remove-debug-log-for-monitoring
Jul 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jun 29, 2021
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
michel-laterman
approved these changes
Jun 29, 2021
Seems to be a CI error.. will retrigger. |
/test |
Running Elastic Agent using debug mode would result in leaking credentials for the monitoring of the local logs and metrics. This PR remove the configuration to be exposed via the debug logging statements. We can receive the same information by running the `inspect` subcommand this require access to the local machine and the necessary privileges to read the files.
ph
force-pushed
the
remove-debug-log-for-monitoring
branch
from
June 29, 2021 19:27
1c3004d
to
e75964c
Compare
urso
approved these changes
Jun 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring Running Elastic Agent using debug mode would result in leaking credentials for the monitoring of the local logs and metrics. This PR remove the configuration to be exposed via the debug logging statements. We can receive the same information by running the `inspect` subcommand this require access to the local machine and the necessary privileges to read the files. * Changelog * Add PR number, run make check Co-authored-by: michel-laterman <[email protected]> (cherry picked from commit c3925fc)
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring Running Elastic Agent using debug mode would result in leaking credentials for the monitoring of the local logs and metrics. This PR remove the configuration to be exposed via the debug logging statements. We can receive the same information by running the `inspect` subcommand this require access to the local machine and the necessary privileges to read the files. * Changelog * Add PR number, run make check Co-authored-by: michel-laterman <[email protected]> (cherry picked from commit c3925fc)
michel-laterman
pushed a commit
that referenced
this pull request
Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring Running Elastic Agent using debug mode would result in leaking credentials for the monitoring of the local logs and metrics. This PR remove the configuration to be exposed via the debug logging statements. We can receive the same information by running the `inspect` subcommand this require access to the local machine and the necessary privileges to read the files. * Changelog * Add PR number, run make check Co-authored-by: michel-laterman <[email protected]> (cherry picked from commit c3925fc) Co-authored-by: Pier-Hugues Pellerin <[email protected]>
michel-laterman
pushed a commit
that referenced
this pull request
Jul 5, 2021
* Reduce the verbosity of the debug log for monitoring Running Elastic Agent using debug mode would result in leaking credentials for the monitoring of the local logs and metrics. This PR remove the configuration to be exposed via the debug logging statements. We can receive the same information by running the `inspect` subcommand this require access to the local machine and the necessary privileges to read the files. * Changelog * Add PR number, run make check Co-authored-by: michel-laterman <[email protected]> (cherry picked from commit c3925fc) Co-authored-by: Pier-Hugues Pellerin <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 8, 2021
* upstream/master: (430 commits) CI: increase timeout (elastic#26764) Heartbeat: add datastream fields to synthetics (elastic#26774) Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775) Remove experimental warning for inputs with variables. (elastic#26762) Add latest k8s versions in testing (elastic#26729) change type of max_bytes to ByteType (elastic#26699) [Elastic Agent] Fix broken enrollment command (elastic#26749) Update agent managed manifest to include enrolment token variable (elastic#26756) Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737) Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754) Upgrade PyYAML dependency used for tests (elastic#26746) Add agent fleet enrolment k8s manifest (elastic#26566) CI: retry the step only (elastic#26736) Osquerybeat: Fix the configuration poll interval setting (elastic#26739) [Filebeat] Replace copy_from with templated value (elastic#26631) Reduce the verbosity of the debug log for monitoring (elastic#26583) Add instructions on testing metricbeat kubernetes module (elastic#26643) Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704) Packaging: linux/armv7 is not supported (elastic#26706) Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v7.14.0
Automated backport with mergify
backport-v7.15.0
Automated backport with mergify
review
Team:Elastic-Agent
Label for the Agent team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Elastic Agent using debug mode would result in leaking
credentials for the monitoring of the local logs and metrics. This
PR remove the configuration to be exposed via the debug logging statements.
We can receive the same information by running the
inspect
subcommandthis require access to the local machine and the necessary privileges to
read the files.
What does this PR do?
Why is it important?
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs