Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pr 247 (fix sed usage) #253

Merged
merged 5 commits into from
Sep 17, 2015
Merged

Merge pr 247 (fix sed usage) #253

merged 5 commits into from
Sep 17, 2015

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Sep 17, 2015

This was already reviewed in #247, but merging via an extra branch because master is protected.

darxriggs and others added 5 commits September 15, 2015 23:27
* when using sed with -i it's crucial to not put any spaces between -i and SUFFIX
  * good: sed -i.bk ...
  * bad:  sed -i .bk ...
* otherwise this error is shown when using GNU sed 4.2.2:
  sed: -e expression #1, char 1: unknown command: `.'
* this is already down in other places in Makefile
ruflin added a commit that referenced this pull request Sep 17, 2015
Merge pr 247 (fix sed usage)
@ruflin ruflin merged commit 1ca0c09 into elastic:master Sep 17, 2015
ruflin added a commit that referenced this pull request Dec 2, 2015
urso pushed a commit that referenced this pull request Dec 2, 2015
Update to most recent libbeat version and shared files
tsg pushed a commit to tsg/beats that referenced this pull request Jan 20, 2016
tsg pushed a commit to tsg/beats that referenced this pull request Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants