Fix sed usage #247
Merged
Fix sed usage #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when using sed with -i it's crucial to not put any spaces between -i and SUFFIX * good: sed -i.bk ... * bad: sed -i .bk ... * otherwise this error is shown when using GNU sed 4.2.2: sed: -e expression elastic#1, char 1: unknown command: `.'
* this is already down in other places in Makefile
|
LGTM, but I'm curious, on which OS didn't the previous version (with space) work? |
|
It didn't work on Ubuntu 14.04 LTS. The used sed is GNU sed 4.2.2 (as mentioned in the commit). I also found a commit of yours cb72d3a. Looks like you already faced this issue and fixed it in one occasion. Btw, do you really want to create backup files? Most of the time they are just deleted right afterwards. (The suffix after -i is optional.) |
|
This was merged. The missing -i suffix doesn't seem to work on OS X :-(, which is from where we normally call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.