Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Handle POLICY_REASSIGN action #24616

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[Fleet] Handle POLICY_REASSIGN action #24616

merged 1 commit into from
Mar 18, 2021

Conversation

nchaulet
Copy link
Member

Description

Resolve #24447
Handle POLICY_REASSIGN action

When an agent get a POLICY_REASSIGN action it should ack the action and checkin again to get the new policy.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 17, 2021
@nchaulet nchaulet added the Team:Elastic-Agent Label for the Agent team label Mar 17, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 17, 2021
@nchaulet nchaulet marked this pull request as ready for review March 17, 2021 20:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@nchaulet nchaulet self-assigned this Mar 17, 2021
@nchaulet nchaulet requested a review from blakerouse March 17, 2021 20:57
blakerouse
blakerouse approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, it just needs to Ack. Then Agent will reconnect to get the latest policy.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24616 opened

  • Start Time: 2021-03-17T20:56:16.494+0000

  • Duration: 52 min 52 sec

  • Commit: 57d1349

Test stats 🧪

Test Results
Failed 0
Passed 6580
Skipped 16
Total 6596

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6580
Skipped 16
Total 6596

@nchaulet nchaulet merged commit f8ca092 into elastic:master Mar 18, 2021
@nchaulet nchaulet deleted the feature-policy-reassign branch March 18, 2021 13:33
@nchaulet nchaulet mentioned this pull request Mar 18, 2021
Merged
nchaulet added a commit to nchaulet/beats that referenced this pull request Mar 18, 2021
@nchaulet
[Fleet] Handle POLICY_REASSIGN action (elastic#24616)
d59a9e1
@nchaulet nchaulet added the Team:Fleet Label for the Fleet team label Mar 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/fleet (Team:Fleet)

nchaulet added a commit that referenced this pull request Mar 22, 2021
@nchaulet
[Fleet] Handle POLICY_REASSIGN action (#24616) (#24631)
a3c950b
@ph ph mentioned this pull request Mar 26, 2021
Closed
@nchaulet nchaulet mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@nchaulet nchaulet

Labels
Team:Elastic-Agent Label for the Agent team Team:Fleet Label for the Fleet team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Support POLICY_REASSIGN action
3 participants
@nchaulet @elasticmachine @blakerouse