Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #24219 to 7.x: Store cloudfoundry.container.cpu.pct in decimal form #24234

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Cherry-pick #24219 to 7.x: Store cloudfoundry.container.cpu.pct in decimal form #24234

merged 1 commit into from
Mar 1, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 25, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24219 to 7.x branch. Original message:

What does this PR do?

  • Store cloudfoundry.container.cpu.pct in decimal form.
  • Store it as a scaled_float.
  • Remove existing helper for common code that doesn't make so sense to reuse now.

Change is breaking, but it doesn't affect to existing dashboards, and this module is in beta stage.

Why is it important?

It is preferred to store percentages in decimal form, and scaled_float is enough to store them.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@jsoriano
Store cloudfoundry.container.cpu.pct in decimal form (elastic#24219)
7615de1 
Percentages should be stored in decimal form, and can be stored as
scaled floats.

Some code is refactored to remove previous helper that makes less sense
now.

(cherry picked from commit 2cf650c)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 25, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 25, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Victor Martinez

  • Start Time: 2021-02-25T11:08:46.110+0000

  • Duration: 48 min 37 sec

  • Commit: 7615de1

Test stats 🧪

Test Results
Failed 0
Passed 9138
Skipped 2250
Total 11388

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9138
Skipped 2250
Total 11388

@jsoriano jsoriano self-assigned this Feb 25, 2021
@jsoriano jsoriano added the Team:Platforms Label for the Integrations - Platforms team label Feb 25, 2021
@jsoriano jsoriano merged commit 4c9360b into elastic:7.x Mar 1, 2021
@jsoriano jsoriano deleted the backport_24219_7.x branch March 1, 2021 13:48
@zube zube bot removed the [zube]: Done label May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@jsoriano jsoriano

Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @kaiyan-sheng