-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common Fields for Container Inventory Schema #22179
Comments
Pinging @elastic/integrations-platforms (Team:Platforms) |
We may also want to check what Cloudwatch/Stackdriver/Azure monitor provide ootb |
@jsoriano @ChrsMark Question about docker network metrics: I see we have both Also do you think it's useful to calculate one value |
Yes,
Yes, this can be interesting, specially for inventory UIs. |
@simianhacker Does UI do any aggregation right now for docker network metrics? |
@neptunian FYI |
@kaiyan-sheng Yes... we use |
@simianhacker Thanks! Is Kibana doing aggregation across all network interfaces for these two counters? |
Yes, we take the derivative of the max of each interface and sum the rates together. |
Proposing new container fields to add into ECS:
@simianhacker Will @ChrsMark @jsoriano @sorantis I would like to hear your opinion on this before starting RFC in ECS. Thanks!! |
Aligning container and hosts ECS metric fields sounds like a good start.
Question about |
LGTM, thanks!
It can be interesting to add them, but we would need to define them well. For the state we would need to define valid values, that can be different between platforms, and if healthchecks should be considered. Uptime can be also different in different platforms, perhaps we should report creation and/or start times instead.
As these metrics are going to be used for UIs and inventory purposes I think we should keep it simple and report a single value for memory usage. I guess that other more specific metrics will still be available in reported events (depending on the availability in the platform), so users can still check them if needed. Regarding the memory metric to derive the common field from, I think it should be derived from the same metric the platform uses to enforce memory limits. This way what users see is consistent with how the platform behaves. For example in #25428 we saw that the only metric kubernetes reports for Windows containers is workingSetBytes, and we decided to use this to calculate the memory percentage usage. |
+1 on well defining the state/update metrics before adding them to ECS. The reason I was asking about including RSS is because I'm seeing it being used as an equally important metric for monitoring container memory. We can review this once we'll have more customer feedback. |
@kaiyan-sheng @sorantis I guess this will help us solving elastic/kibana#100229, right? |
@ChrsMark Yes I think this is a perfect use case for defining and adopting inventory schema. |
Hi @akshay-saraswat and @ChrsMark, here are the two issues I created: |
@MichaelKatsoulis since you are planning to working on this do you think we can take the ownership? @jsoriano @kaiyan-sheng any objections on this? |
No objectios 🙂 Thanks a lot! |
Yes |
Continuing the discussion on this.
After looking at Metrics UI Inventory page , I can see that in the dropdown list there are
Comparing the cpu percentages of The best step forward would be to make the Those fields will be populated by either As different modules can populated same fields at the same time it is vital all the different modules (currently kubernetes and docker. In the future containerd as well) will report same values for those fields. So I suggest that Those additional fields are:
|
Good job in breaking this down @MichaelKatsoulis ! Regarding the new fields you propose, can you also share the types for them? We can upvote for them in this issue and then I guess we can go ahead and open a PR to ECS. Regarding the views. I find your approach valid. The @jasonrhodes I think that the UI team need to pair with us on this decision making. Anyone available to work on this? |
@ChrsMark,
and the updated I also believe that |
This issue tracks work related to the definition of common fields for container inventory schema.
The output will be a set of recommended or required fields to be added to any event related to containers.
The purpose of these fields is to have a minimal set of valuable data that can be used for inventory. The focus will be in metadata and metrics fields.
Integrations possibly affected:
Related issues
The text was updated successfully, but these errors were encountered: