Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22892 to 7.x: [Filebeat][Cisco] Fix umbrella config: add input var #22894

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 3, 2020

Cherry-pick of PR #22892 to 7.x branch. Original message:

What does this PR do?

Adds input var to cisco umbrella config

Why is it important?

Config expects input variable to be either s3 or file but none is provided, breaking the default config.

The error we get is:
Exiting: Error getting config for fileset cisco/umbrella: Error interpreting the template of the input: template: text:1:9: executing "text" at <.input>: map has no entry for key "input"

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 3, 2020
@marc-gr marc-gr requested a review from a team December 3, 2020 14:57
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22894 opened

  • Start Time: 2020-12-03T14:56:56.006+0000

  • Duration: 47 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 1970
Skipped 259
Total 2229

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1970
Skipped 259
Total 2229

@marc-gr marc-gr merged commit 6515d79 into elastic:7.x Dec 3, 2020
@marc-gr marc-gr deleted the backport_22892_7.x branch December 3, 2020 15:44
@zube zube bot removed the [zube]: Done label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants