[Filebeat][Cisco] Fix umbrella config: add input var #22892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
|
This pull request doesn't have a |
marc-gr
force-pushed
the
fix-umbrella-config
branch
from
06ad748 to
2d2ede5
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
urso
approved these changes
Dec 3, 2020
|
Thank you. Please backport to 7.x and 7.10 branch (fix might be in 7.10.2) |
2 tasks
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Dec 3, 2020
(cherry picked from commit e5fc1be)
2 tasks
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Dec 3, 2020
(cherry picked from commit e5fc1be)
marc-gr
added a commit
that referenced
this pull request
Dec 3, 2020
marc-gr
added a commit
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds input var to cisco umbrella config
Why is it important?
Config expects
inputvariable to be eithers3orfilebut none is provided, breaking the default config.The error we get is:
Exiting: Error getting config for fileset cisco/umbrella: Error interpreting the template of the input: template: text:1:9: executing "text" at <.input>: map has no entry for key "input"Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.