Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22575 to 7.x: Packetbeat agent interface and procs configuration #22601

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Nov 16, 2020

Cherry-pick of PR #22575 to 7.x branch. Original message:

What does this PR do?

This PR acts as a stop-gap to allow for grouped streams to configure a packetbeat sniffer. As discussed in #22227 this currently does the (dumb) thing of just grabbing an interface configuration from any of the streams -- so if you have multiple streams specified, you should make sure they all have the same interface configuration. The next step will be to do some additional lifecycle management changes and spin off new packet sniffers based on configurations that differ, removing the coupling.

I put in a couple of tests to demonstrate the funky, but currently expected, behavior.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22601 opened]

  • Start Time: 2020-11-16T19:13:50.589+0000

  • Duration: 42 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 1081
Skipped 10
Total 1091

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1081
Skipped 10
Total 1091

@leehinman leehinman merged commit 361a743 into elastic:7.x Nov 16, 2020
@zube zube bot removed the [zube]: Done label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants