Packetbeat agent interface and procs configuration #22575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
Nov 16, 2020
…ormation (elastic#22575) (cherry picked from commit 36f28bf)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR acts as a stop-gap to allow for grouped streams to configure a packetbeat sniffer. As discussed in #22227 this currently does the (dumb) thing of just grabbing an interface configuration from any of the streams -- so if you have multiple streams specified, you should make sure they all have the same interface configuration. The next step will be to do some additional lifecycle management changes and spin off new packet sniffers based on configurations that differ, removing the coupling.
I put in a couple of tests to demonstrate the funky, but currently expected, behavior.
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues