Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22543 to 7.x: [Elastic Agent] Fix sysv init files for deb/rpm installation #22593

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Cherry-pick #22543 to 7.x: [Elastic Agent] Fix sysv init files for deb/rpm installation #22593

merged 2 commits into from
Nov 18, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #22543 to 7.x branch. Original message:

What does this PR do?

Fixes the sysv init files so it works on deb/rpm systems that use sysv and not systemd.

Why is it important?

So deb/rpm work on sysv init systems.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse
[Elastic Agent] Fix sysv init files for deb/rpm installation (elastic…
6cda660 
…#22543)

* Fix sysv init files for deb/rpm.

* Add changelog.

(cherry picked from commit c403d1c)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2020
@blakerouse blakerouse self-assigned this Nov 16, 2020
@elasticmachine
Copy link
Collaborator

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Test stats 🧪

Test Results
Failed 1
Passed 15821
Skipped 1239
Total 17061

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Build&Test / metricbeat-goIntegTest / TestFetch – status

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 16, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22593 updated]

  • Start Time: 2020-11-18T13:43:26.437+0000

  • Duration: 66 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 16385
Skipped 1371
Total 17756

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16385
Skipped 1371
Total 17756

ph
ph approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport LGTM but haven't tested it.

@blakerouse blakerouse merged commit 42e731b into elastic:7.x Nov 18, 2020
@blakerouse blakerouse deleted the backport_22543_7.x branch November 18, 2020 15:39
@ph ph mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees

@blakerouse blakerouse

Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @elasticmachine @ph