-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Fix sysv init files for deb/rpm installation #22543
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
Can we target 7.x and 7.10 so it goes in 7.10.1? |
@rahulgupta-qasource and @EricDavisX this solve the recent issues we found in debian9 or other based sysv system. |
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
/packaging |
@ph will backport to 7.10 |
it would be great to do the possibly minimal work to get the .rpm/.deb tests back running in the e2e-testing repo here elastic/e2e-testing#379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @EricDavisX /@ph We are blocked to validate this ticket for 7.10.1 BC1 .rpm(on CentOS7 machine) and .deb(on Debian9 machine) packages on 7.10.1 BC1 Kibana cloud environment(deployed from staging platform) due to bug #22744
Once the above bug #22744 is fixed, we will validate this ticket. |
discussed with team we will target additional fixes in 7.11.0 and 7.10.2 - we are past the date for 7.10.1 fixes to routinely be discussed and since it is not functioning in 7.10 we aren't any worse than we were. we can do a thorough testing run in 22744 in later cycle. |
Hi @EricDavisX We have performed regression testing for Linux deb/rpm on 7.10.2 BC1 Kibana cloud build. Build details is as follows:
We have execute test cases under test plan execution :
Please let us know if anything else is required to be covered. Thanks |
What does this PR do?
Fixes the sysv init files so it works on deb/rpm systems that use sysv and not systemd.
Why is it important?
So deb/rpm work on sysv init systems.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues