Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20396 to 7.x: [Filebeat][SophosXG Module] Renaming module and fileset #20408

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Aug 3, 2020

Cherry-pick of PR #20396 to 7.x branch. Original message:

What does this PR do?

Renaming module from SophosXG to Sophos, and fileset from firewall to XG.

This allows us to easier add more fileset under the more generally named Sophos module

Why is it important?

Makes adding new filesets to Sophos easier and cleaner.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

Module already has a PR Changelog entry, and has not been released yet, so removing the checkbox for changelog

Updated golden files with:

MODULES_PATH=$PWD/module GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=sophos nosetests -v -s tests/system/test_xpack_modules.py

renaming sophosxg module to sophos, and renaming fileset to better support future filesets

(cherry picked from commit 778a92f)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 3, 2020
@adriansr adriansr added the review label Aug 3, 2020
@zube zube bot removed the [zube]: In Review label Aug 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 3, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20408 updated]

  • Start Time: 2020-08-03T17:21:33.226+0000

  • Duration: 58 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 5504
Skipped 824
Total 6328

@adriansr adriansr merged commit 637e7cf into elastic:7.x Aug 4, 2020
@zube zube bot removed the [zube]: Done label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants