[Filebeat][SophosXG Module] Renaming module and fileset #20396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport future filesets
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
jenkins run the tests please |
adriansr
approved these changes
Aug 3, 2020
| @@ -1355,9 +1355,9 @@ filebeat.modules: | |||
| # The port to listen for syslog traffic. Defaults to 9004. | |||
| #var.syslog_port: 9005 | |||
|
|
|||
| # firewall default hostanme | |||
| # firewall default hostanme | |||
adriansr
pushed a commit
to adriansr/beats
that referenced
this pull request
Aug 3, 2020
renaming sophosxg module to sophos, and renaming fileset to better support future filesets (cherry picked from commit 778a92f)
5 tasks
5 tasks
adriansr
pushed a commit
to adriansr/beats
that referenced
this pull request
Aug 3, 2020
renaming sophosxg module to sophos, and renaming fileset to better support future filesets (cherry picked from commit 778a92f)
adriansr
added a commit
that referenced
this pull request
Aug 4, 2020
…e and fileset (#20408) renaming sophosxg module to sophos, and renaming fileset to better support future filesets (cherry picked from commit 778a92f) Co-authored-by: Marius Iversen <[email protected]>
adriansr
added a commit
that referenced
this pull request
Aug 4, 2020
) renaming sophosxg module to sophos, and renaming fileset to better support future filesets (cherry picked from commit 778a92f) Co-authored-by: Marius Iversen <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 6, 2020
…ne-2.0 * upstream/master: [docs] Promote ingest management to beta (elastic#20295) Upgrade elasticsearch client library used in tests (elastic#20405) Disable logging when pulling on python integration tests (elastic#20397) Remove pillow from testing requirements.txt (elastic#20407) [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440) [Ingest Manager] Send datastreams fields (elastic#20402) Add event.ingested to all Filebeat modules (elastic#20386) [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426) Improve cgroup_regex docs with examples (elastic#20425) Makes `metrics` config option required in app_insights (elastic#20406) Ensure install scripts only install if needed (elastic#20349) Update container name for the azure filesets (elastic#19899) Group same timestamp metrics values in app_insights metricset (elastic#20403) add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767) Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547) [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396) Update Suricata dashboards (elastic#20394) [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359) Prepare home directories for docker images in a different stage (elastic#20356)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 6, 2020
…allation * upstream/master: (23 commits) [docs] Promote ingest management to beta (elastic#20295) Upgrade elasticsearch client library used in tests (elastic#20405) Disable logging when pulling on python integration tests (elastic#20397) Remove pillow from testing requirements.txt (elastic#20407) [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440) [Ingest Manager] Send datastreams fields (elastic#20402) Add event.ingested to all Filebeat modules (elastic#20386) [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426) Improve cgroup_regex docs with examples (elastic#20425) Makes `metrics` config option required in app_insights (elastic#20406) Ensure install scripts only install if needed (elastic#20349) Update container name for the azure filesets (elastic#19899) Group same timestamp metrics values in app_insights metricset (elastic#20403) add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767) Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547) [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396) Update Suricata dashboards (elastic#20394) [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359) Prepare home directories for docker images in a different stage (elastic#20356) New multiline mode in Filebeat: while_pattern (elastic#19662) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
renaming sophosxg module to sophos, and renaming fileset to better support future filesets
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… (elastic#20409) renaming sophosxg module to sophos, and renaming fileset to better support future filesets (cherry picked from commit 584223c) Co-authored-by: Marius Iversen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renaming module from SophosXG to Sophos, and fileset from firewall to XG.
This allows us to easier add more fileset under the more generally named Sophos module
Why is it important?
Makes adding new filesets to Sophos easier and cleaner.
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Module already has a PR Changelog entry, and has not been released yet, so removing the checkbox for changelog
Updated golden files with:
MODULES_PATH=$PWD/module GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=sophos nosetests -v -s tests/system/test_xpack_modules.py