Add missing inputs to filebeat spec #20388
Conversation
urso
added
review
Filebeat
botelastic
bot
added
needs_team
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
|
|
I think the ones we add we should also test and make sure they actually work as expect. There is also an other aspect here: We renamed |
|
jenkins run the tests please |
urso
force-pushed
the
agent-fb-whitelist
branch
from
9850157 to
5cd0a23
Compare
There was a problem hiding this comment.
The code change LGTM. The part that we should follow up is on what are the inputs that we test and support and what are the inputs that we just enabled. In general, inputs should just work and as you described, perhaps we don't even need the list anymore in the end. But lets take this discussion to a different place.
@urso Could you think of some input names you are not happy with that we should rename? One example is that we renamed logto logfile.
|
Maybe for now we shouldn't rename them at all. From Integrations POV the current name is just a small detail that most users should not be concerned about. The way we structure inputs/streams might be more important, but let's discuss that tomorrow :) |
By adding the inputs to the list, they can be used by integrations. For example awscloudwatch, http_endpoint, unix, and winlog inputs have been missing. (cherry picked from commit 0520635)
urso
added
v7.10.0
and removed
needs_backport
…ne-2.0 * upstream/master: (39 commits) [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558) [Heartbeat] Fix packaging (elastic#20566) [Heartbeat] Add Magefile to X-Pack (elastic#20549) [Packetbeat] Add "network" to event.category (elastic#20392) fix typo in docs (elastic#20541) Add service resource in k8s cluster role (elastic#20546) Update Golang version to 1.14.7 (elastic#20508) Add missing inputs to filebeat spec (elastic#20388) add warning log in aws and googlecloud module for API cost (elastic#20523) Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335) [CI] add more resilience (elastic#20505) [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537) [ITs] change healthcheck for elasticsearch (elastic#20514) [JJBB] fix credentials with a service account (elastic#20535) chore(ci): use build step for checking if is PR (elastic#20536) [CI] runbld project name (elastic#20466) Add panw.panos.endreason field (elastic#18705) [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808) Fix typo in netflow module docs (elastic#18992) Modified auditd ingest pipeline to handle node=hostname (elastic#19659) ...
By adding the inputs to the list, they can be used by integrations. For example awscloudwatch, http_endpoint, unix, and winlog inputs have been missing.
What does this PR do?
Add missing inputs to the filebeat spec whitelist
Why is it important?
By adding the inputs to the list, they can be used by integrations. For example awscloudwatch, http_endpoint, unix, and winlog inputs have been missing.
@ruflin @ph Do we even need the whitelist? What about naming. There is some translation, but only for some inputs. Most inputs are just available based on the original name.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues