Fix typo in netflow module docs #18992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
|
💚 CLA has been signed |
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
andrewkroh
added
needs CLA
|
I have now signed the contributor agreement. All this to fix a typo. |
|
@andrewkroh I've signed the CLA. I would be chuffed if my single character typo fix could make it through the paperwork but I feel like this process is not really set up for such trivial things! |
|
jenkins run tests |
marc-gr
removed
the
needs CLA
|
Thanks for your contribution @rruckley! When changing documentation we need to re-generate some files, you can do so by running |
|
Also you'll need to point to PR to the |
|
Thanks for catching this! Sorry this easy fix is so complicated. I will apply your commit to master and run |
|
Thank you, I wasn't really looking to become a full developer but it's nice to get these little things fixed. |
Fixed typo, line 47, Address to bind to
|
run tests |
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
andrewkroh
approved these changes
Aug 10, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 12, 2020
…ne-2.0 * upstream/master: (39 commits) [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558) [Heartbeat] Fix packaging (elastic#20566) [Heartbeat] Add Magefile to X-Pack (elastic#20549) [Packetbeat] Add "network" to event.category (elastic#20392) fix typo in docs (elastic#20541) Add service resource in k8s cluster role (elastic#20546) Update Golang version to 1.14.7 (elastic#20508) Add missing inputs to filebeat spec (elastic#20388) add warning log in aws and googlecloud module for API cost (elastic#20523) Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335) [CI] add more resilience (elastic#20505) [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537) [ITs] change healthcheck for elasticsearch (elastic#20514) [JJBB] fix credentials with a service account (elastic#20535) chore(ci): use build step for checking if is PR (elastic#20536) [CI] runbld project name (elastic#20466) Add panw.panos.endreason field (elastic#18705) [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808) Fix typo in netflow module docs (elastic#18992) Modified auditd ingest pipeline to handle node=hostname (elastic#19659) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Updated netflow.asciidoc Fixed typo, line 47, Address to bind to * Update source file for netflow docs Co-authored-by: Andrew Kroh <[email protected]>
5 tasks
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Feb 16, 2021
* Updated netflow.asciidoc Fixed typo, line 47, Address to bind to * Update source file for netflow docs Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 091f66d)
jsoriano
added a commit
that referenced
this pull request
Feb 17, 2021
(cherry picked from commit 091f66d) Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes typo in netflow config documentation (s/find/bind/).
Why is it important?
Sloppy spelling gives bad impression for Elastic.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.