Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fail if not possible to install python3 #19164

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 12, 2020

What does this PR do?

Script didn't fail when the python installation with choco failed.

Why is it important?

To be able to retry before running the tests.

Screenshots

image

Logs

[2020-06-12T14:58:26.130Z] By installing you accept licenses for the packages.
[2020-06-12T15:23:03.350Z] python not installed. An error occurred during installation:
[2020-06-12T15:23:03.350Z]  Unable to read package from path 'python3.3.8.2.nupkg'.
[2020-06-12T15:23:03.350Z] python package files install completed. Performing other installation steps.
[2020-06-12T15:23:03.350Z] The install of python was NOT successful.
[2020-06-12T15:23:03.350Z] python not installed. An error occurred during installation:
[2020-06-12T15:23:03.350Z]  Unable to read package from path 'python3.3.8.2.nupkg'.
[2020-06-12T15:23:03.350Z] 
[2020-06-12T15:23:03.350Z] Chocolatey installed 0/1 packages. 1 packages failed.
[2020-06-12T15:23:03.350Z]  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
[2020-06-12T15:23:03.350Z] 
[2020-06-12T15:23:03.350Z] Failures
[2020-06-12T15:23:03.350Z]  - python (exited 1) - python not installed. An error occurred during installation:
[2020-06-12T15:23:03.350Z]  Unable to read package from path 'python3.3.8.2.nupkg'.
[2020-06-12T15:23:03.350Z] 
[2020-06-12T15:23:03.350Z] C:\Users\jenkins\workspace\Beats_beats-beats-mbp_PR-18695\src\github.com\elastic\beats>python --version 
[2020-06-12T15:23:03.350Z] Python 2.7.16
[2020-06-12T15:23:03.350Z] 
[2020-06-12T15:23:03.350Z] C:\Users\jenkins\workspace\Beats_beats-beats-mbp_PR-18695\src\github.com\elastic\beats>where python 
[2020-06-12T15:23:03.350Z] C:\Python27\python.exe

See build log

@v1v v1v self-assigned this Jun 12, 2020
@v1v v1v added the automation label Jun 12, 2020
@v1v v1v requested a review from a team June 12, 2020 15:41
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@v1v v1v added Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 12, 2020
@v1v v1v marked this pull request as ready for review June 12, 2020 15:42
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19164 opened]

  • Start Time: 2020-06-12T15:41:34.412+0000

  • Duration: 78 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 9127
Skipped 1570
Total 10697

Steps errors

Expand to view the steps failures

  • Name: Make -C filebeat testsuite

    • Description: make -C filebeat testsuite

    • Duration: 7 min 7 sec

    • Start Time: 2020-06-12T16:04:30.579+0000

    • log

  • Name: Install docker-compose 1.21.0

    • Description: .ci/scripts/install-docker-compose.sh

    • Duration: 1 min 57 sec

    • Start Time: 2020-06-12T16:04:17.613+0000

    • log

  • Name: Install Go 1.13.10

    • Description: .ci/scripts/install-go.sh

    • Duration: 1 min 8 sec

    • Start Time: 2020-06-12T16:04:03.437+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-06-12T16:59:21.420Z] >> python test: Unit Testing Complete
[2020-06-12T16:59:21.569Z] Recording test results
[2020-06-12T16:59:25.557Z] Stashed 2 file(s)
[2020-06-12T16:59:25.577Z] Archiving artifacts
[2020-06-12T16:59:30.138Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats
[2020-06-12T16:59:30.473Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-06-12T16:59:30.497Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Lint
[2020-06-12T16:59:30.660Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Winlogbeat-oss
[2020-06-12T16:59:30.812Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-06-12T16:59:30.961Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-06-12T16:59:31.112Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Dockerlogbeat
[2020-06-12T16:59:31.283Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Journalbeat-oss
[2020-06-12T16:59:31.438Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-06-12T16:59:31.595Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-06-12T16:59:31.743Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Filebeat-oss
[2020-06-12T16:59:31.897Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-06-12T16:59:32.067Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-06-12T16:59:32.230Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-06-12T16:59:32.383Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Heartbeat-oss
[2020-06-12T16:59:32.535Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-06-12T16:59:32.686Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-06-12T16:59:32.841Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-06-12T16:59:32.997Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-06-12T16:59:33.164Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-06-12T16:59:33.318Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Libbeat-x-pack
[2020-06-12T16:59:33.474Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-06-12T16:59:33.631Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-06-12T16:59:33.786Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-06-12T16:59:33.940Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-06-12T16:59:34.095Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Filebeat-Windows
[2020-06-12T16:59:34.245Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Packetbeat-oss
[2020-06-12T16:59:34.398Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-06-12T16:59:34.552Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-06-12T16:59:34.702Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-06-12T16:59:34.857Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-06-12T16:59:35.013Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-Windows
[2020-06-12T16:59:35.166Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Filebeat-x-pack
[2020-06-12T16:59:35.320Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-06-12T16:59:35.471Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-06-12T16:59:35.622Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-06-12T16:59:35.776Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-06-12T16:59:35.930Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-06-12T16:59:36.080Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-06-12T16:59:36.232Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-06-12T16:59:36.387Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Libbeat-oss
[2020-06-12T16:59:36.539Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Functionbeat-Windows
[2020-06-12T16:59:36.690Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-06-12T16:59:36.842Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-06-12T16:59:36.992Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-06-12T16:59:37.143Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-06-12T16:59:37.304Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-06-12T16:59:37.459Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Heartbeat-Windows
[2020-06-12T16:59:37.893Z] + cat
[2020-06-12T16:59:37.893Z] + /usr/local/bin/runbld ./runbld-script
[2020-06-12T16:59:37.893Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-06-12T16:59:44.464Z] runbld>>> runbld started
[2020-06-12T16:59:44.464Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-06-12T16:59:45.843Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-19164' in order of occurrence in the config (last value wins).
[2020-06-12T16:59:47.226Z] runbld>>> Debug logging enabled.
[2020-06-12T16:59:47.226Z] runbld>>> Storing result
[2020-06-12T16:59:47.226Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-06-12T16:59:47.226Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200612165946-D86EED27
[2020-06-12T16:59:47.226Z] runbld>>> Adding system facts.
[2020-06-12T16:59:48.166Z] runbld>>> Adding vcs info for the latest commit:  0bc02d652c6a68003653772afe332dc6e88bf3cd
[2020-06-12T16:59:48.426Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-06-12T16:59:48.426Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-06-12T16:59:48.426Z] + echo 'Processing JUnit reports with runbld...'
[2020-06-12T16:59:48.426Z] Processing JUnit reports with runbld...
[2020-06-12T16:59:48.994Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-06-12T16:59:48.994Z] runbld>>> DURATION: 16ms
[2020-06-12T16:59:48.994Z] runbld>>> STDOUT: 40 bytes
[2020-06-12T16:59:48.994Z] runbld>>> STDERR: 49 bytes
[2020-06-12T16:59:48.994Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-06-12T16:59:48.994Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats
[2020-06-12T16:59:50.374Z] runbld>>> Storing build metadata: 
[2020-06-12T16:59:50.374Z] runbld>>> Adding test report.
[2020-06-12T16:59:50.374Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats
[2020-06-12T16:59:51.311Z] runbld>>> Found 114 test output files
[2020-06-12T16:59:51.583Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-06-12T16:59:51.583Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-06-12T16:59:51.843Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-06-12T16:59:51.843Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-cloudfoundry.xml
[2020-06-12T16:59:51.843Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-06-12T16:59:51.843Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-06-12T16:59:51.843Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-06-12T16:59:51.843Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-06-12T16:59:53.753Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 10547 Skipped: 1331
[2020-06-12T16:59:53.753Z] runbld>>> Storing result
[2020-06-12T16:59:53.753Z] runbld>>> FAILURES: 0
[2020-06-12T16:59:53.753Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-06-12T16:59:53.753Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200612165946-D86EED27
[2020-06-12T16:59:53.753Z] runbld>>> Email notification disabled by environment variable.
[2020-06-12T16:59:53.753Z] runbld>>> Slack notification disabled by environment variable.
[2020-06-12T16:59:59.613Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19164
[2020-06-12T16:59:59.922Z] [INFO] getVaultSecret: Getting secrets
[2020-06-12T16:59:59.993Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-12T17:00:01.659Z] + chmod 755 generate-build-data.sh
[2020-06-12T17:00:01.659Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19164/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19164/runs/1 FAILURE 4706955
[2020-06-12T17:00:01.659Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19164/runs/1/steps/?limit=10000 -o steps-info.json
[2020-06-12T17:00:03.521Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19164/runs/1/tests/?status=FAILED -o tests-errors.json

@v1v v1v merged commit 477324b into elastic:master Jun 15, 2020
@v1v v1v deleted the fix/installation-tools-pipeline branch June 15, 2020 06:41
v1v added a commit to v1v/beats that referenced this pull request Jun 15, 2020
v1v added a commit to v1v/beats that referenced this pull request Jun 15, 2020
…ngs-archive

* upstream/master:
  Fix minor spelling error in Jenkinsfile (elastic#19153)
  [CI] fail if not possible to install python3 (elastic#19164)
  [Elastic Agent] Improved mage demo experience (elastic#18445)
  [yum] Clear cached data and add retry loop (elastic#19182)
  fix lint job by updating NOTICE (elastic#19161)
  Fix tags for coredns/envoyproxy (elastic#19134)
  Disable host.* fields by default for CrowdStrike module (elastic#19132)
  Allow host.* fields to be disabled in Zeek module (elastic#19113)
  Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114)
  Edit Elastic Agent docs (elastic#19146)
  [JJBB] create job definition for the golang-crossbuild project (elastic#19162)
  Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052)
  Add basic cloudfoundry integration tests (elastic#19018)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
v1v added a commit to v1v/beats that referenced this pull request Oct 16, 2020
v1v added a commit that referenced this pull request Oct 30, 2020
* cherry-pick aad07ad
* Add stages to Jenkins pipeline (#14484)
* ci: avoid to modify go.mod file (#16842)
* Ensure install scripts only install if needed (#20349)
* ci: fix warnings with wildcards and archive system-tests (#18695)
* ci: run test on Windows (#15570)
* [CI] fail if not possible to install python3 (#19164)
* [CI] lint stage doesn't produce test reports (#21888)
* [CI] Add stage name in the step (#21887)
* [CI] kind setup fails sometimes (#21857)
* [CI] refactor runbld post build action (#21256)
* [CI] Archive build reasons (#21347)
* [CI] Fix runbld when workspace does not exist (#21350)
* [CI] Send slack message with build status (#21428)
* [CI] Setup git config globally (#21562)
* [CI] fix 'no matches found within 10000' (#21466)
* [CI] Change notification channel (#21559)
* [CI] Support skip-ci label (#21377)
* [BUILD][CI] fetch dependencies with retry (#21614)
* Disable x-pack/metricbeat in linux since build is broken #21962
* Disable tests for windows in auditbeat. See #21958
* Disable integration testing for libbeat. See #21959
* Disable integration testing for metricbeat. See #21961
* Disable windows build for auditbeat. See #21958
* Disable build for libbeat. See #21959
* Disable build for metricbeat. See #21961
* Disable windows build for metricbeat. See #22257
* Disable build for x-pack/metricbeat. See #21962
* Disable windows build for x-pack/winlogbeat. See #22263
* Disable windows build for x-pack/filebeat. See #21963
* integration-tests-environment is not available for winlogbeat. see #22265
* integration-tests-environment is not available for packetbeat. see #22266
* Build not available for x-pack/metricbeats in 6.8. See #22269
* Cherry-pick 96c60d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants