Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic cloudfoundry integration tests #19018

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 5, 2020

What does this PR do?

Add some basic integration tests for cloudfoundry.

By now these tests follow the approach we are following with cloud features, they need a cloud foundry deployment whose configuration is provided using environment variables, and tests are only executed if some tag is set. So they are not going to be executed in CI by now.

Instructions to have a working cloud foundry deployment will be added in a future PR.

Why is it important?

To have some integration tests as reference before starting with further refactors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation Instructions to have a cloud foundry deployment for development will be added in a future PR.
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

export CLOUDFOUNDRY_API_ADDRESS=...
export CLOUDFOUNDRY_CLIENT_ID=...
export CLOUDFOUNDRY_CLIENT_SECRET=...
go test -tags=integration,cloudfoundry ./x-pack/filebeat/input/cloudfoundry/ ./x-pack/metricbeat/module/cloudfoundry/...

Related issues

  • Part of elastic/beats#17539

@jsoriano jsoriano added review :Testing [zube]: In Review Team:Platforms Label for the Integrations - Platforms team labels Jun 5, 2020
@jsoriano jsoriano self-assigned this Jun 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 5, 2020
@jsoriano
Copy link
Member Author

jenkins, run the tests please

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 10, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19018 updated]

  • Start Time: 2020-06-10T12:08:33.291+0000

  • Duration: 64 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 3696
Skipped 509
Total 4205

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Really like the testing!

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.9.0 labels Jun 12, 2020
@jsoriano jsoriano merged commit 600f5a8 into elastic:master Jun 12, 2020
@jsoriano jsoriano deleted the cloudfoundry-integration-tests branch June 12, 2020 15:00
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Jun 12, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Jun 12, 2020
v1v added a commit to v1v/beats that referenced this pull request Jun 15, 2020
…ngs-archive

* upstream/master:
  Fix minor spelling error in Jenkinsfile (elastic#19153)
  [CI] fail if not possible to install python3 (elastic#19164)
  [Elastic Agent] Improved mage demo experience (elastic#18445)
  [yum] Clear cached data and add retry loop (elastic#19182)
  fix lint job by updating NOTICE (elastic#19161)
  Fix tags for coredns/envoyproxy (elastic#19134)
  Disable host.* fields by default for CrowdStrike module (elastic#19132)
  Allow host.* fields to be disabled in Zeek module (elastic#19113)
  Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114)
  Edit Elastic Agent docs (elastic#19146)
  [JJBB] create job definition for the golang-crossbuild project (elastic#19162)
  Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052)
  Add basic cloudfoundry integration tests (elastic#19018)
jsoriano added a commit that referenced this pull request Jun 15, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team :Testing v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants