Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the injectPreferV2Template decorator #18431

Merged
merged 1 commit into from
May 11, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented May 11, 2020

What does this PR do?

Removes the injectPreferV2Template as its no longer needed in 7.8 because of elastic/elasticsearch#56546.

Why is it important?

The parameters no longer exists so it must be removed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 11, 2020
@blakerouse blakerouse marked this pull request as ready for review May 11, 2020 20:17
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph added [zube]: In Review review needs_backport PR is waiting to be backported to other branches. labels May 11, 2020
@ph
Copy link
Contributor

ph commented May 11, 2020

@blakerouse We will need to forward port to 7.x, master doesn't have that inject code.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@blakerouse blakerouse merged commit e0953fc into elastic:7.8 May 11, 2020
@blakerouse blakerouse deleted the revert-prefer-v2-7.8 branch May 11, 2020 21:05
@blakerouse blakerouse removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@blakerouse blakerouse added v7.9.0 [zube]: Done and removed needs_backport PR is waiting to be backported to other branches. [zube]: In Review labels May 12, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants