Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Revert logic in place to add the prefer_v2_template #18428

Closed
ph opened this issue May 11, 2020 · 5 comments
Closed

[Elastic Agent] Revert logic in place to add the prefer_v2_template #18428

ph opened this issue May 11, 2020 · 5 comments
Assignees
Labels
blocker Ingest Management:alpha1 Group issues for ingest management alpha1

Comments

@ph
Copy link
Contributor

ph commented May 11, 2020

The Elasticsearch team will remove the requirement to send the prefer_v2_templates on every bulk request to enforce the use of v2 templates.

Because of this we have to revert in part the code in #18318 that inject the parameter option to the elasticsearch output but we should keep the change for the parameters since it does fix a bug in ES output.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 11, 2020
@ph ph added blocker elastic-agent Ingest Management:alpha1 Group issues for ingest management alpha1 and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor Author

ph commented May 11, 2020

@BlakeRous can you take a look at this need to go in with the Elasticsearch PR, I think we can have the PR ready and we can synchronize the merge.

@BlakeRous
Copy link

BlakeRous commented May 11, 2020 via email

@ph
Copy link
Contributor Author

ph commented May 11, 2020

@BlakeRous oh typo, I've missed the e. sorry about that, I was faster than the autocomplete. I've meant @blakerouse

@ph
Copy link
Contributor Author

ph commented May 11, 2020

The Elasticsearch PR is up at elastic/elasticsearch#56546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Ingest Management:alpha1 Group issues for ingest management alpha1
Projects
None yet
Development

No branches or pull requests

4 participants