-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #17391 to 7.x: [Agent] Rename agent to elastic-agent #17599
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
@michalpristas don't merge it yet, I have another fix to go in. |
Fails here: vet: management/fleet/manager.go:36:13: undeclared name: Config |
@michalpristas I've fixed all the bugs and diverging code from master to 7.x, I've run |
libbeat failures is related checking it out. |
@@ -629,7 +629,7 @@ func (b *Beat) configure(settings Settings) error { | |||
logp.Info("Beat ID: %v", b.Info.ID) | |||
|
|||
// initialize config manager | |||
b.ConfigManager, err = management.Factory()(b.Config.Management, reload.Register, b.Beat.Info.ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's weird that this is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-pack/libbeat/management/fleet
is missing entirely in branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check this PR and especially this test update to make libbeat pass
https://github.com/elastic/beats/pull/14835/files#diff-cf1cbef8b594350a8858a0682701458eR76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird le met check that. I have it locally I might not have pushed it but I still have issues with the libbeat system test.
[Agent] Rename agent to elastic-agent (elastic#17391) (cherry picked from commit 66609a3)
* Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested.
* Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested.
* handle windows correctly
[Agent] Fix merge of config elastic#17399
@michalpristas I've went back to all the PRs I've backported and I did missed some files, so I tried to understand what happened and I just failed at the big merges. So I've think I've go everything now in this PR. Please take a look all tests were running locally will take a look at the CI this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, thanks @ph
Cherry-pick of PR #17391 to 7.x branch. Original message:
What does this PR do?
This PR renames agent to elastic-agent.
packaging tested.
configuration variables such as
agent.id
are kept the same without a name change.Why is it important?
To provide less generic name for executable
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Fixes #17239