-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Agent] Handle abs paths on windows correctly #17461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ingest-management (Project:fleet) |
6 tasks
ph
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets get the jenkins changes in before so we can test it on CI.
ph
added
needs_backport
PR is waiting to be backported to other branches.
Team:Ingest Management
labels
Apr 3, 2020
I've looked at our lint job and this look like some instability from Jenkins:
|
backported in #17599 |
ph
pushed a commit
to ph/beats
that referenced
this pull request
Apr 10, 2020
* handle windows correctly
ph
added a commit
that referenced
this pull request
Apr 14, 2020
) * [Agent] Rename agent to elastic-agent (#17391) [Agent] Rename agent to elastic-agent (#17391) (cherry picked from commit 66609a3) * Add Elastic Agent in the Jenkinsfile (#17445) * Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested. * Add Elastic Agent in the Jenkinsfile (#17445) * Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested. * [Agent] Fix merge of config (#17399) [Agent] Fix merge of config #17399 * [Agent] Handle abs paths on windows correctly (#17461) * handle windows correctly * Missing commits from the initial merges of the agent -> master Co-authored-by: Michal Pristas <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If absolute path in unix format is used in config, IsAbs on windows returns false. so we first transform it to windows path format and then handle the logic as usual.
For transformation volume of root directory passed is used, it is usually a directory where installed beat is located.
Why is it important?
Supporting windows
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Fixes #17449