Add subscriptions metricset of nats module #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
ruflin
reviewed
Jan 18, 2019
CHANGELOG.asciidoc
Outdated
| - Add `nats` module with `stats` metricset. {pull}9825[9825] | ||
| - Add `connections` metricset to the `nats` module. {pull}10095[10095] | ||
| - Add `routes` metricset to the `nats` module. {pull}10095[10095] | ||
| - Add `nats` module. {issue}10071[10071] |
There was a problem hiding this comment.
You can remove it here, it's only needed in the next changelog.
|
jenkins, test this |
|
This CI failure looks related: |
|
cc: @skatsaounis , @ChrsMark |
Signed-off-by: Michael Katsoulis <[email protected]> Co-Authored-By: Christos Markou <[email protected]> Co-Authored-By: Stamatis Katsaounis <[email protected]>
Signed-off-by: Michael Katsoulis <[email protected]> Co-Authored-By: Christos Markou <[email protected]> Co-Authored-By: Stamatis Katsaounis <[email protected]>
Signed-off-by: Michael Katsoulis <[email protected]> Co-Authored-By: Christos Markou <[email protected]> Co-Authored-By: Stamatis Katsaounis <[email protected]>
|
jenkins, test this |
|
I merged the changelog conflict, let's see if CI goes green now. |
ruflin
added
module
review
Metricbeat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
subscriptionsmetricset to nats module as part of #10071.subscriptionsmetricset retrieves metrics from subsz monitoring URI of nats.Co-Authored-By: Christos Markou [email protected]
Co-Authored-By: Stamatis Katsaounis [email protected]