-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Nats modules #10071
Comments
@ruflin just a design question, as far as the addition of the remaining metricsets is concerned. Initially we had 4 metricsets, one for each of the NATS' monitoring URIS, |
I don't know much about |
This PR adds `connections` metricset to `nats` module as part of #10071. `connections` metricset retrieves metrics from `connz` [monitoring](https://nats.io/documentation/tutorials/nats-monitoring/) URI of `nats`. _______________________________________________________________________________ Co-Authored-By: Stamatis Katsaounis <[email protected]>, @skatsaounis Co-Authored-By: Michael Katsoulis <[email protected]>, @MichaelKatsoulis
@skatsaounis @ChrsMark Any chance you could also contribute some dashboards for this module? |
This PR adds `routes` metricset to `nats` module as part of #10071. `routes` metricset retrieves metrics from `routez` [monitoring](https://nats.io/documentation/tutorials/nats-monitoring/) URI of `nats`. _______________________________________________________________________________ Co-Authored-By: Christos Markou <[email protected]> Co-Authored-By: Michael Katsoulis <[email protected]>
Hi @ruflin, We are going to do it after merging the last metricset patch. In terms of completeness of NATS module is there something else we are missing? |
@skatsaounis Will go through the checklist above as soon as we got all the PR's in. I think dashboards and Is there also potential here for a filebeat modules for Nats? I assume it has some logs ... |
This PR adds `subscriptions` metricset to nats module as part of #10071. `subscriptions` metricset retrieves metrics from subsz monitoring URI of nats. Co-Authored-By: Christos Markou <[email protected]> Co-Authored-By: Stamatis Katsaounis <[email protected]>
This PR adds an overview dashboard for `nats` module as proposed on #10071. Co-Authored-By: Stamatis Katsaounis <[email protected]> Co-Authored-By: Michael Katsoulis <[email protected]>
@ChrsMark I updated this issue to not only track the metricbeat Nats module but also the Filebeat one. For creating the Filebeat module the most important first step is to get some logs from nats to play around with and figure how many different log types there are. |
@ruflin I wan to inform you that I am going to create a PR to Kibana regarding Nats Metrics Home Tutorial. As soon as it is ready I am going to mention this issue to make it visible here. |
@ruflin If you could find some time it would be nice to have this issue's checklist updated. |
@skatsaounis Sorry for the late reply, was of for a bit. It seems from the above, only thing missing is dashboards for the Filebeat modules? |
@ruflin Indeed. When we close the enhancements PR we are going to open another one to add a dashboard |
This PR is part of #10071. Co-Authored-By: Christos Markou <[email protected]> Co-Authored-By: Michael Katsoulis <[email protected]>
This PR is part of #10071. Co-Authored-By: Stamatis Katsaounis <[email protected]> Co-Authored-By: Michael Katsoulis <[email protected]>
@ruflin Hi Nicolas! Thank you for merging the Filebeat Dashboard related PRs. May I ask you what is missing to consider the NATS work as complete? We would love to see NATS Filbeat module become part of version 7 as well. PS: The last checkpoint can be marked as complete 😄 |
Thanks for all the work on this. I'm going to close this issue. For the releases: The metricbeat module will be in 7.0 but the Filebeat module came in after feature freeze so will only make it into 7.1. |
Beats Modules / Datasets release checklist
This checklist is intended for Devs which create or update a module to make sure modules are consistent.
Modules
For a metricset to go GA, the following criterias should be met:
Filebeat module
Metricbeat module
data.json
exists and an automated way to generate it exists (go test -data
)The text was updated successfully, but these errors were encountered: