Update script with curly braces in the script #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and consistent Conflicts: load.sh
| @@ -74,7 +74,7 @@ case $1 in | |||
|
|
|||
| *) | |||
| echo "Error: Unknown option $2" | |||
| print_usage | |||
| print_usageUSER | |||
There was a problem hiding this comment.
Ouch, this is wrong and :( not planned typo, and why we have to check the code. I have to delete 'USER' part of the string.
|
Except for the one comment, LGTM. It seems like #83 can be closed because the |
|
LGTM except for the part discovered by @andrewkroh . @radoondas Let us know when you pushed the change as Github does not send notifications for new commits. |
|
@ruflin I have just pushed fix to github. Could someone please double check? |
ruflin
added a commit
that referenced
this pull request
Feb 9, 2016
Update script with curly braces in the script
|
@radoondas LGTM. Merged. |
This was referenced Feb 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simple update which adds 'curly-braces'
Extending: #83