Rename variable name to uppercase NAME #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a minor naming update of the script. In SHELL script usually all variables are uppercase. Is there any reason for variable name' to be lowercase?
|
is there any reason to have name in uppercase either? assignment of variables is case sensitive in shells as well (typically). |
| $CURL -XPUT $ELASTICSEARCH/$KIBANA_INDEX/search/$name \ | ||
| NAME=`basename $file .json` | ||
| echo "Loading search $NAME:" | ||
| $CURL -XPUT $ELASTICSEARCH/$KIBANA_INDEX/search/$NAME \ |
There was a problem hiding this comment.
We could be very careful here and make it ${NAME}
|
Well yes. On the other hand I would suggest not only ${NAME}, but more curly braces where variables are in the strings to be more safe and consistenst within the script. I will create PR later, with additions. |
|
@radoondas Thanks |
…to the script This is more as a draft to be discussed. it will work for any beat if you configure it's mask in configfile. Script doesn't touch original files, it creates tmp file instead. Please, have a look and comment.
…ces' in to the script" This reverts commit 38f60b0.
…ing to ES This modification expect config file, where necessary renaming is defined. This file can be empty or doesn't need to exist. Script doesn't touch original files, it creates temp files instead. This also works with other custom visualizations - just add your names and your set to go. This solution requires further discussion.
|
For the reference, I have prepared another commit to my fork with curly braces in the script: 6e1948d I have no PR so far. I believe, further discussion is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor naming update of the script.
Is there any reason for variable 'name' to be lowercase?