-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update network connection fields #5671
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
f1fa462
to
4ab0d69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the urgency of this PR being backported to 7.14
? Does the iOS agent not work with the current fields, or would the network.connection*
fields just be ignored?
@simitt I mentioned to Andrew in slack: we don't need to backport this to 7.14; I've been holding off on updating the agent with these spec changes due to the Otel spec change not being merged yet. |
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
Change network.connection_type to network.connection.type, and add network.connection.subtype. Rename model.Carrier to model.NetworkCarrier to clarify its position within the document hierarchy.
Support agents sending "network.connection.type" ("n.c.t" in RUMv3) in metadata, which will be added to all events in the stream. This is currently intended for RUM. In the future we may want to support setting this at the even level too, to cater for operation-specific network information.
4ab0d69
to
06bedaf
Compare
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
* Update OTel network connection type conventions * Add network.connection.subtype field Change network.connection_type to network.connection.type, and add network.connection.subtype. Rename model.Carrier to model.NetworkCarrier to clarify its position within the document hierarchy. * model/modeldecoder: add "network.connection.type" Support agents sending "network.connection.type" ("n.c.t" in RUMv3) in metadata, which will be added to all events in the stream. This is currently intended for RUM. In the future we may want to support setting this at the even level too, to cater for operation-specific network information. * Update changelog (cherry picked from commit d1ebfd4) # Conflicts: # changelogs/head.asciidoc # include/fields.go
* Update network connection fields (#5671) * Update OTel network connection type conventions * Add network.connection.subtype field Change network.connection_type to network.connection.type, and add network.connection.subtype. Rename model.Carrier to model.NetworkCarrier to clarify its position within the document hierarchy. * model/modeldecoder: add "network.connection.type" Support agents sending "network.connection.type" ("n.c.t" in RUMv3) in metadata, which will be added to all events in the stream. This is currently intended for RUM. In the future we may want to support setting this at the even level too, to cater for operation-specific network information. * Update changelog (cherry picked from commit d1ebfd4) # Conflicts: # changelogs/head.asciidoc # include/fields.go * Fix merge conflicts Co-authored-by: Andrew Wilkins <[email protected]>
Cannot yet be tested as the latest version of the iOS agent does not contain the change; it still sends @bryce-b any update on when this will be changed in the agent? |
@Silvia These changes will be in this week. |
Motivation/summary
The OTel semantic conventions for network connection type have evolved:
net.host.connection_type
is nownet.host.connection.type
andnet.host.connection.subtype
. See open-telemetry/opentelemetry-specification#1759. This PR extends #5436 to adapt to these changes.Support Elastic APM agents sending "network.connection.type" ("n.c.t" in RUMv3) in metadata, which will be added to all events in the stream. This is currently intended for RUM. In the future we may want to support setting this at the even level too, to cater for operation-specific network information.
Finally, the Elasticsearch field names have been changed to
network.connection.type
andnetwork.connection.subtype
.Checklist
- [ ] Documentation has been updatedHow to test these changes
network.connection.type
andnetwork.connection.subtype
fields are recordedRelated issues
#5203