Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for mobile network connectivity attributes #5203

Closed
bryce-b opened this issue Apr 30, 2021 · 5 comments · Fixed by #5436
Closed

Add fields for mobile network connectivity attributes #5203

bryce-b opened this issue Apr 30, 2021 · 5 comments · Fixed by #5436

Comments

@bryce-b
Copy link
Contributor

bryce-b commented Apr 30, 2021

  • The following fields need to be added:
    net.host.connection_type: 5G,4G,3G,2G,1G, wifi,unavailable (String)
    net.host.carrier.mcc : mobile country codes (String)
    net.host.carrier.mnc : mobile network codes (String)
    net.host.carrier.name: Carrier names (String) (e.g.: T-Mobile, AT&T, etc)
    net.host.carrier.icc: 2-character iso country code (String) (e.g.: US, DE)

  • These fields also need to be added into ECS

Note: Here are related tickets
OpenTelemetry spec issue
iOS agent ticket

@simitt simitt added the iOS label Jun 1, 2021
@simitt simitt added the v7.14.0 label Jun 1, 2021
@simitt simitt added this to the 7.14 milestone Jun 1, 2021
@zube zube bot added [zube]: Ready and removed [zube]: Inbox labels Jun 1, 2021
@bryce-b
Copy link
Contributor Author

bryce-b commented Jun 1, 2021

Here's a link to a rudimentary test app for generating iOS data: https://github.com/elastic/ios-integration-testing
It requires MacOS.
the apm server ip/url can be set in this file : https://github.com/elastic/ios-integration-testing/blob/master/Shared/Model/ios_integration_testingApp.swift
Let me know if you need help getting it set up.

@axw
Copy link
Member

axw commented Jun 2, 2021

We should keep #4912 in mind when we do this - specifically there's overlap on net.host.connection_type.

@jalvz
Copy link
Contributor

jalvz commented Jun 9, 2021

@bryce-b should any of these fields be required?

@bryce-b
Copy link
Contributor Author

bryce-b commented Jun 9, 2021

@jalvz what are the implications of being 'required'? Will the traces be ignored if they are not attached? If so, they shouldn't be required.

@jalvz
Copy link
Contributor

jalvz commented Jun 9, 2021

Exactly, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants