[fix] move from keyword to wildcards for ECS fields #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align type with ECS types for overwritten fields. closes elastic#4448
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
Codecov Report
@@ Coverage Diff @@
## master #4577 +/- ##
=======================================
Coverage 75.96% 75.96%
=======================================
Files 161 161
Lines 9789 9789
=======================================
Hits 7436 7436
Misses 2353 2353 |
|
Tests are failing because of a corrupted Kibana container. |
axw
approved these changes
Dec 23, 2020
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Dec 28, 2020
Align type with ECS types for overwritten fields. closes elastic#4448
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Dec 28, 2020
Align type with ECS types for overwritten fields. closes elastic#4448
simitt
added a commit
that referenced
this pull request
Dec 28, 2020
simitt
added a commit
that referenced
this pull request
Dec 28, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Types have not been changed from keyword to wildcard when pulling in the latest beats update. Index Pattern generation is broken since then, as the same field name is defined with different types.
This PR aligns the type with ECS types introduced in beats for overwritten fields.
Checklist
How to test these changes
Check that template has
wildcardas type for changed fieldsRelated issues
closes #4448