aggregation/txmetrics: drop user-agent parsing #4439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUM-specific charts have been removed from the APM app, and these metrics are not currently required by the User Experience app.
Codecov Report
@@ Coverage Diff @@
## master #4439 +/- ##
==========================================
+ Coverage 76.14% 76.21% +0.07%
==========================================
Files 157 156 -1
Lines 9724 9694 -30
==========================================
- Hits 7404 7388 -16
+ Misses 2320 2306 -14
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
simitt
approved these changes
Nov 18, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Dec 10, 2020
RUM-specific charts have been removed from the APM app, and these metrics are not currently required by the User Experience app.
axw
added a commit
that referenced
this pull request
Dec 14, 2020
|
Tested with BC1 - sent transactions with equal and different user agent request headers and observed no difference in grouping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Remove user-agent from transaction metrics, and all related config and processing. RUM-specific charts have been removed from the APM app, and these metrics are not currently required by the User Experience app. Drop the TODOs about adding country name while we're at it.
Checklist
- [ ] I have updated CHANGELOG.asciidoc(not yet user-facing)I have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
Related issues
#3613 (comment)
elastic/kibana#77458