Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP enrichment processor #3613

Closed
axw opened this issue Apr 3, 2020 · 4 comments
Closed

GeoIP enrichment processor #3613

axw opened this issue Apr 3, 2020 · 4 comments
Assignees

Comments

@axw
Copy link
Member

axw commented Apr 3, 2020

For #3485 we will need to perform GeoIP enrichment early enough to incorporate into latency histogram aggregation keys, to enable the RUM map visualisation. We (currently) just need the country ISO code.

Ideally we would bundle the MaxMind GeoLite2 database, and enable users to load their own commercially licensed copy of GeoIP2, like Elasticsearch does.

@graphaelli graphaelli added this to the 7.9 milestone May 6, 2020
@jalvz jalvz self-assigned this Jun 4, 2020
@axw axw removed this from the 7.9 milestone Aug 10, 2020
@axw
Copy link
Member Author

axw commented Nov 16, 2020

Since the RUM-specific charts have been removed from the APM UI (elastic/kibana#77458), I don't think we need to incorporate geo information into transaction metrics any more, and we should be remove the browser name from the transaction metrics.

In the new Client Side Monitoring app, it is possible to visualise a breakdown by location, device, and more. This app, however, does not expect data to be pre-aggregated. The RUM agent will continue to send "unsampled" transactions so that users can perform high fidelity, ad-hoc breakdowns.

@sqren @dgieselaar @andrewvc can you please let me know if this is accurate?

@sorenlouv
Copy link
Member

sorenlouv commented Nov 16, 2020

This is accurate for now at least. I don't know if the longer term plans are for the UX app to also transition to pre-aggregated transactions. @vigneshshanmugam / @jahtalab / @shahzad31 would know.

@paulb-elastic
Copy link

Although we may have a need for this in the future, it is unclear what they will be now. As such, please go ahead with your changes, and we will consider our implementation if/when we need to do this. (cc @jahtalab)

@axw
Copy link
Member Author

axw commented Nov 18, 2020

Thanks @paulb-elastic, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants