-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom response headers for RUM endpoints #3820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
reviewed
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor suggestions for the YAML comments.
Co-authored-by: Andrew Wilkins <[email protected]>
I guess we need to white-list this on Cloud. Any contrary opinions? |
Codecov Report
@@ Coverage Diff @@
## master #3820 +/- ##
=======================================
Coverage 80.01% 80.01%
=======================================
Files 137 137
Lines 6195 6195
=======================================
Hits 4957 4957
Misses 1238 1238 |
axw
approved these changes
May 27, 2020
jalvz
added a commit
to jalvz/apm-server
that referenced
this pull request
May 27, 2020
Co-authored-by: Andrew Wilkins <[email protected]>
jalvz
added a commit
that referenced
this pull request
May 28, 2020
Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have considered changes for:
How to test these changes
Configure some headers in apm-server.rum.response_headers, send a request to any/all rum endpoints, and observe those headers in the response. Should work for both strings and lists
Related issues
Closes #3696
Docs issue #3821