Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom response headers for RUM endpoints #3820

Merged
merged 5 commits into from
May 27, 2020
Merged

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented May 26, 2020

Checklist

I have considered changes for:

How to test these changes

Configure some headers in apm-server.rum.response_headers, send a request to any/all rum endpoints, and observe those headers in the response. Should work for both strings and lists

Related issues

Closes #3696
Docs issue #3821

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggestions for the YAML comments.

_meta/beat.yml Outdated Show resolved Hide resolved
Co-authored-by: Andrew Wilkins <[email protected]>
@apmmachine
Copy link
Contributor

apmmachine commented May 27, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #3820 updated]

  • Start Time: 2020-05-27T12:02:48.252+0000

  • Duration: 47 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 3230
Skipped 145
Total 3375

@jalvz
Copy link
Contributor Author

jalvz commented May 27, 2020

I guess we need to white-list this on Cloud. Any contrary opinions?

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #3820 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3820   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         137      137           
  Lines        6195     6195           
=======================================
  Hits         4957     4957           
  Misses       1238     1238           

@jalvz jalvz requested a review from axw May 27, 2020 12:46
@jalvz jalvz merged commit a93a1ef into elastic:master May 27, 2020
jalvz added a commit to jalvz/apm-server that referenced this pull request May 27, 2020
jalvz added a commit that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable RUM response headers
4 participants